refactor: make objects set-access access a positional arg

src/lib/objects/set-access.ts

@@ -14,20 +14,30 @@ export default async function setAccess(options: Record<string, unknown>) {
 
   const bucketArg = getOption<string>(options, ['bucket']);
   const keyArg = getOption<string>(options, ['key']);
-  const access = getOption<string>(options, ['access', 'a', 'A']);
+  const accessArg = getOption<string>(options, ['access']);
 
   if (!bucketArg) {
     failWithError(context, 'Bucket name or path is required');
   }
 
-  const { bucket, key } = resolveObjectArgs(bucketArg, keyArg);
+  // When the user passes a full t3://bucket/key path as the first
+  // positional, the second positional slot is the access value and
+  // there is no third. Mirrors the resolution shape in objects put.
+  const combined = resolveObjectArgs(bucketArg);
+  const bucket = combined.bucket;
+  const key = combined.key || keyArg;
+  const access = combined.key ? keyArg : accessArg;
 
   if (!key) {
     failWithError(context, 'Object key is required');
   }
 
+  if (!access) {
+    failWithError(context, 'Access level is required (public or private)');
+  }
+
   if (access !== 'public' && access !== 'private') {
-    failWithError(context, '--access must be either "public" or "private"');
+    failWithError(context, 'Access level must be either "public" or "private"');
   }
 
   const config = await getStorageConfig();

src/specs.yaml

@@ -1395,8 +1395,8 @@ commands:
         description: Set the access level (public or private) on an existing object
         alias: sa
         examples:
-          - "tigris objects set-access my-bucket my-file.txt --access public"
-          - "tigris objects set-access t3://my-bucket/my-file.txt --access private"
+          - "tigris objects set-access my-bucket my-file.txt public"
+          - "tigris objects set-access t3://my-bucket/my-file.txt private"
         messages:
           onStart: 'Updating object access...'
           onSuccess: "Access for '{{key}}' updated to {{access}}"
@@ -1410,10 +1410,9 @@ commands:
             description: Key of the object (omit if bucket contains the full path)
             type: positional
           - name: access
-            description: Access level
-            alias: a
+            description: Access level (public or private)
+            type: positional
             options: *access_options
-            required: true
           - name: format
             description: Output format
             options: [json, table, xml]

test/cli.test.ts

@@ -1756,23 +1756,39 @@ describe.skipIf(skipTests)('CLI Integration Tests', () => {
       runCli(`rm ${t3(testBucket)}/${testFile} -f`);
     });
 
-    it('should set --access public', () => {
+    it('should set access to public via positional', () => {
       const result = runCli(
-        `objects set-access ${testBucket} ${testFile} --access public`
+        `objects set-access ${testBucket} ${testFile} public`
       );
       expect(result.exitCode).toBe(0);
     });
 
-    it('should set --access private', () => {
+    it('should set access to private via positional', () => {
+      const result = runCli(
+        `objects set-access ${testBucket} ${testFile} private`
+      );
+      expect(result.exitCode).toBe(0);
+    });
+
+    it('should accept t3:// path with access as second positional', () => {
       const result = runCli(
-        `objects set-access ${testBucket} ${testFile} --access private`
+        `objects set-access ${t3(testBucket)}/${testFile} public`
       );
       expect(result.exitCode).toBe(0);
     });
 
-    it('should error on missing --access', () => {
+    it('should error when the access positional is missing', () => {
       const result = runCli(`objects set-access ${testBucket} ${testFile}`);
       expect(result.exitCode).toBe(1);
+      expect(result.stderr).toContain('Access level is required');
+    });
+
+    it('should error on invalid access value', () => {
+      const result = runCli(
+        `objects set-access ${testBucket} ${testFile} maybe`
+      );
+      expect(result.exitCode).toBe(1);
+      expect(result.stderr).toContain('Access level must be either');
     });
   });