Resolve combined-image binary via PATH instead of /usr/bin/calico#4805
Draft
caseydavenport wants to merge 1 commit into
Draft
Resolve combined-image binary via PATH instead of /usr/bin/calico#4805caseydavenport wants to merge 1 commit into
caseydavenport wants to merge 1 commit into
Conversation
Switches CalicoBinaryPath (and the csi-node-driver-registrar command) from absolute paths to bare commands so they resolve via PATH. Keeps us agnostic to where the binary lives in the image: legacy Dockerfile builds use /usr/bin/calico, ko-built images use /ko-app/calico. Both paths are on PATH. Companion to the ko-build prototype in projectcalico/calico#12710.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch
CalicoBinaryPath(and the csi-node-driver-registrar command) from absolute paths to bare commands so they resolve via PATH. The legacy Dockerfile build puts the binary at/usr/bin/calico; the ko-built image puts it at/ko-app/calico. Both/usr/binand/ko-appare on PATH, so a bare command works either way.Why
Companion to projectcalico/calico#12710 (ko-build prototype). Without this, the operator-managed pods can't start when the calico image is ko-built — the absolute path no longer exists in the image.
Test plan