Skip to content

Delay marking degraded due to readiness for 60s #4675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caseydavenport wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Delay marking degraded due to readiness for 60s #4675

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1928d07
Delay marking degraded due to readiness for 60s
caseydavenport Apr 11, 2026
6192356
Merge remote-tracking branch 'origin/master' into casey-delay-readine…
caseydavenport Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/controller/status/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,10 +704,12 @@ func (m *statusManager) podsFailing(selector *metav1.LabelSelector, namespace st
}

// If none of the container-level checks matched, check if the pod is running but
// not passing readiness checks.
// not passing readiness checks. We only note a pod as failing if it has been
// unready for over a minute, to minimize false positives.
if p.Status.Phase == corev1.PodRunning {
for _, cond := range p.Status.Conditions {
if cond.Type == corev1.ContainersReady && cond.Status == corev1.ConditionFalse {
old := time.Now().Sub(cond.LastTransitionTime.Time) > 60*time.Second
if cond.Type == corev1.ContainersReady && cond.Status == corev1.ConditionFalse && old {
return fmt.Sprintf("Pod %s/%s is running but not ready", p.Namespace, p.Name), nil
}
}
Expand Down
Loading