refactor(velodyne): generic decoder

[mojomex]

PR Type

• Improvement

Related Links

• refactor(velodyne): implement generic velodyne decoder #144 -- @ike-kazu's work
• refactor(velodyne): implement generic velodyne decoder #138 -- @bgilby59's work

Description

Continuation of #144, which was a continuation of #138.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[knzo25]

@mojomex
Is this PR still active?

[mojomex]

@knzo25 This is not yet in a mergeable state, and given that priority is low and resources are scarce, I'm inclined to call it a day. @drwnz what's your take on this?

As for the work that would have to be done:

• cross-check with all three datasheets
• test with various parameter options (scan cutting, return mode, etc.)