-
Notifications
You must be signed in to change notification settings - Fork 21
feat(T4MetricV2): add object distributions to T4MetricV2 dataframe #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(T4MetricV2): add object distributions to T4MetricV2 dataframe #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables test set object distribution tracking by adding object distribution metadata to T4MetricV2 dataframes. The changes allow loading pre-computed test set statistics from parquet files instead of regenerating them during evaluation.
Changes:
- Added
testing_statistics_parquet_pathparameter to T4MetricV2 and T4MetricV2DataFrame for loading test set statistics - Extended T4DatasetStatistics to capture object distributions (area, volume, orientation, translation, velocity, etc.) per class
- Removed
sample_id_to_prefix_mappingfrom evaluation processing as test distributions are now loaded from parquet files
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/detection3d/t4dataset_converters/t4dataset_statistics.py | Implements object distribution collection for all classes with predefined schema and extraction logic |
| tools/detection3d/create_data_t4dataset.py | Updates statistic collection to pass infos and bev_distance_range to add_samples |
| projects/CenterPoint/configs/t4dataset/Centerpoint/second_secfpn_4xb16_121m_j6gen2_base_amp_t4metric_v2.py | Adds testing_statistics_parquet_path to configuration |
| projects/CenterPoint/configs/t4dataset/Centerpoint/second_secfpn_4xb16_121m_base_amp_t4metric_v2.py | Adds testing_statistics_parquet_path to configuration |
| autoware_ml/detection3d/evaluation/t4metric/t4metric_v2_dataframe.py | Loads and joins test statistics parquet to evaluation dataframe |
| autoware_ml/detection3d/evaluation/t4metric/t4metric_v2.py | Removes sample_id_to_prefix_mapping logic and accepts testing_statistics_parquet_path |
| autoware_ml/configs/detection3d/dataset/t4dataset/j6gen2_base.py | Simplifies dataset_test_groups to single entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
This PR adds distributions of objects when creating info pickles files and save them to a parquet file based on their split. It also support to load metadata for test set from the parquet file instead of generating them when running evaluation.
Change point
testing_statistics_parquet_pathtoT4MetricV2[1]._process_evaluator_resultsto removesample_id_to_prefix_mapping[2]._process_metrics_for_aggregationto removesample_id_to_prefix_mapping[3].T4MetricV2DataFrameto includetesting_statistics_parquet_path[4].Test performed