Updating for mars() engine-specific args

Author: juliasilge

R/mars.R

@@ -93,7 +93,8 @@ update.mars <-
            parameters = NULL,
            num_terms = NULL, prod_degree = NULL, prune_method = NULL,
            fresh = FALSE, ...) {
-    update_dot_check(...)
+
+    eng_args <- update_engine_parameters(object$eng_args, ...)
 
     if (!is.null(parameters)) {
       parameters <- check_final_param(parameters)
@@ -109,12 +110,15 @@ update.mars <-
 
     if (fresh) {
       object$args <- args
+      object$eng_args <- eng_args
     } else {
       null_args <- map_lgl(args, null_value)
       if (any(null_args))
         args <- args[!null_args]
       if (length(args) > 0)
         object$args[names(args)] <- args
+      if (length(eng_args) > 0)
+        object$eng_args[names(eng_args)] <- eng_args
     }
 
     new_model_spec(

tests/testthat/test_mars.R

@@ -78,11 +78,12 @@ test_that('updating', {
   expr1     <- mars() %>% set_engine("earth", model = FALSE)
   expr1_exp <- mars(num_terms = 1) %>% set_engine("earth", model = FALSE)
 
-  expr2     <- mars(num_terms = varying()) %>% set_engine("earth")
+  expr2     <- mars(num_terms = varying()) %>% set_engine("earth", nk = varying())
   expr2_exp <- mars(num_terms = varying()) %>% set_engine("earth", nk = 10)
 
-  expr3     <- mars(num_terms = 1, prod_degree = varying()) %>% set_engine("earth")
-  expr3_exp <- mars(num_terms = 1) %>% set_engine("earth")
+  expr3     <- mars(num_terms = 1, prod_degree = varying()) %>% set_engine("earth", nk = varying())
+  expr3_fre <- mars(num_terms = 1) %>% set_engine("earth", nk = varying())
+  expr3_exp <- mars(num_terms = 1) %>% set_engine("earth", nk = 10)
 
   expr4     <- mars(num_terms = 0) %>% set_engine("earth", nk = 10)
   expr4_exp <- mars(num_terms = 0) %>% set_engine("earth", nk = 10, trace = 2)
@@ -91,7 +92,9 @@ test_that('updating', {
   expr5_exp <- mars(num_terms = 1) %>% set_engine("earth", nk = 10, trace = 2)
 
   expect_equal(update(expr1, num_terms = 1), expr1_exp)
-  expect_equal(update(expr3, num_terms = 1, fresh = TRUE), expr3_exp)
+  expect_equal(update(expr2, nk = 10), expr2_exp)
+  expect_equal(update(expr3, num_terms = 1, fresh = TRUE), expr3_fre)
+  expect_equal(update(expr3, num_terms = 1, fresh = TRUE, nk = 10), expr3_exp)
 
   param_tibb <- tibble::tibble(num_terms = 3, prod_degree = 1)
   param_list <- as.list(param_tibb)