Updating for logistic_reg() engine specific params

Author: juliasilge

R/logistic_reg.R

@@ -115,7 +115,8 @@ update.logistic_reg <-
            parameters = NULL,
            penalty = NULL, mixture = NULL,
            fresh = FALSE, ...) {
-    update_dot_check(...)
+
+    eng_args <- update_engine_parameters(object$eng_args, ...)
 
     if (!is.null(parameters)) {
       parameters <- check_final_param(parameters)
@@ -129,12 +130,15 @@ update.logistic_reg <-
 
     if (fresh) {
       object$args <- args
+      object$eng_args <- eng_args
     } else {
       null_args <- map_lgl(args, null_value)
       if (any(null_args))
         args <- args[!null_args]
       if (length(args) > 0)
         object$args[names(args)] <- args
+      if (length(eng_args) > 0)
+        object$eng_args[names(eng_args)] <- eng_args
     }
 
     new_model_spec(

tests/testthat/test_logistic_reg.R

@@ -181,11 +181,11 @@ test_that('updating', {
   expr1_exp <- logistic_reg(mixture = 0) %>%
     set_engine("glm", family = expr(binomial(link = "probit")))
 
-  expr2     <- logistic_reg(mixture = varying()) %>% set_engine("glmnet")
+  expr2     <- logistic_reg(mixture = varying()) %>% set_engine("glmnet", nlambda = varying())
   expr2_exp <- logistic_reg(mixture = varying()) %>% set_engine("glmnet", nlambda = 10)
 
-  expr3     <- logistic_reg(mixture = 0, penalty = varying())
-  expr3_exp <- logistic_reg(mixture = 1)
+  expr3     <- logistic_reg(mixture = 0, penalty = varying()) %>% set_engine("glmnet", nlambda = varying())
+  expr3_exp <- logistic_reg(mixture = 1) %>% set_engine("glmnet", nlambda = 10)
 
   expr4     <- logistic_reg(mixture = 0) %>% set_engine("glmnet", nlambda = 10)
   expr4_exp <- logistic_reg(mixture = 0) %>% set_engine("glmnet", nlambda = 10, pmax = 2)
@@ -194,7 +194,8 @@ test_that('updating', {
   expr5_exp <- logistic_reg(mixture = 1) %>% set_engine("glmnet", nlambda = 10, pmax = 2)
 
   expect_equal(update(expr1, mixture = 0), expr1_exp)
-  expect_equal(update(expr3, mixture = 1, fresh = TRUE), expr3_exp)
+  expect_equal(update(expr2, nlambda = 10), expr2_exp)
+  expect_equal(update(expr3, mixture = 1, fresh = TRUE, nlambda = 10), expr3_exp)
 
   param_tibb <- tibble::tibble(mixture = 1/3, penalty = 1)
   param_list <- as.list(param_tibb)