Skip to content

Docker configuration fixes#113

Merged
guycipher merged 2 commits intotidesdb:masterfrom
Vettabase:federico-razzoli-patch-1
Apr 13, 2026
Merged

Docker configuration fixes#113
guycipher merged 2 commits intotidesdb:masterfrom
Vettabase:federico-razzoli-patch-1

Conversation

@federico-razzoli
Copy link
Copy Markdown
Contributor

Fixes in the configuration file:

  • Remove deprecated innodb_file_per_table
  • Split [client] and [mariadb-client] because default_character_set is not understood by some clients
  • Use default_character_set with underscore instead of dashes for consistence

@guycipher
Copy link
Copy Markdown
Member

@federico-razzoli the contributor agreement is failing. Could you approve it? The PR looks good

@guycipher
Copy link
Copy Markdown
Member

@federico-razzoli do you have a reference on that config being deprecated and potentially what versions

@guycipher
Copy link
Copy Markdown
Member

"When innodb_file_per_table=ON is set, InnoDB uses one tablespace file per InnoDB table. These tablespace files have the .ibd extension. When innodb_file_per_table=OFF is set, InnoDB stores all tables in the InnoDB system tablespace.
InnoDB versions in MySQL 5.7 and above also support an additional type of tablespace called general tablespaces that are created with CREATE TABLESPACE. However, InnoDB versions in MariaDB Server do not support general tablespaces or CREATE TABLESPACE."

https://mariadb.com/docs/server/server-usage/storage-engines/innodb/innodb-tablespaces/innodb-file-per-table-tablespaces

@federico-razzoli
Copy link
Copy Markdown
Contributor Author

@guycipher It's deprecated since 11.0. Since MariaDB's first version, the default is 1.

When a variable is deprecated, you can see it in the documentation and in the error log.

Documentation:

https://mariadb.com/docs/server/server-usage/storage-engines/innodb/innodb-system-variables#innodb_file_per_table

Error log:

2026-04-10 12:14:06 0 [Warning] --innodb-file-per-table is deprecated and will be removed in a future release

@federico-razzoli
Copy link
Copy Markdown
Contributor Author

For some reason this PR doesn't contain a change I thought it would contain. I need to re-add it.

@federico-razzoli federico-razzoli changed the title Docker configuration fixes [WIP] Docker configuration fixes Apr 12, 2026
Signed-off-by: Federico Razzoli <federico.razzoli@vettabase.com>
Signed-off-by: Federico Razzoli <federico.razzoli@vettabase.com>
@federico-razzoli federico-razzoli force-pushed the federico-razzoli-patch-1 branch from 7102cf3 to d970140 Compare April 12, 2026 00:19
@federico-razzoli federico-razzoli changed the title [WIP] Docker configuration fixes Docker configuration fixes Apr 12, 2026
@federico-razzoli
Copy link
Copy Markdown
Contributor Author

Re-applied lost change and signed off.

Copy link
Copy Markdown
Member

@guycipher guycipher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The charset there per research is the default anyways in MariaDB v10+.

@guycipher guycipher merged commit 97cc230 into tidesdb:master Apr 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants