[WEB-4390] - Install RTK by henry-tp · Pull Request #1862 · tidepool-org/blip

henry-tp · 2026-02-09T21:38:45Z

platform-client: tidepool-org/platform-client#215

I know it's +600 lines but It's not that bad, just renaming a bunch of test cases to use the 'thunk' named export (breaking change)

You can't really test this manually, so here is a branch you can checkout if you want to see it in action:
#1865

Copilot

Pull request overview

This pull request installs Redux Toolkit (RTK) 2.11.2 and upgrades core Redux dependencies to their latest major versions (Redux 5.0.1, redux-thunk 3.1.0, reselect 5.1.0). The primary change is updating all test files to use the named export for redux-thunk middleware, which is a breaking change in redux-thunk 3.x. The PR sets up the foundation for RTK Query by creating a base API configuration with authentication and tracing headers, though no actual API endpoints are defined yet (those will be added in PR #1865).

Changes:

Installed @reduxjs/toolkit 2.11.2 and upgraded Redux from 4.2.1 to 5.0.1, redux-thunk from 2.4.2 to 3.1.0, and reselect from 4.1.8 to 5.1.0
Updated all test files (60+ files) to import redux-thunk middleware as a named export { thunk } instead of default export
Created RTK Query base API configuration with authentication headers, retry logic, and action dispatching for tracking
Integrated RTK Query reducer and middleware into both dev and production store configurations
Updated tidepool-platform-client to pre-release version 0.65.0-web-4390-install-rtk.1 (likely includes getSessionTrace method)

Reviewed changes

Copilot reviewed 62 out of 63 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
package.json	Added @reduxjs/toolkit dependency and upgraded redux, redux-thunk, reselect, and tidepool-platform-client versions
yarn.lock	Updated lockfile with new dependency versions and their transitive dependencies
app/redux/api/baseApi.js	Created new RTK Query base API with authentication, tracing, retry logic, and custom action dispatches
app/redux/constants/actionTypes.js	Added RTK_QUERY_REQUEST_SUCCESS and RTK_QUERY_REQUEST_ERROR action type constants
app/redux/store/configureStore.prod.js	Integrated RTK Query reducer and middleware into production store configuration
app/redux/store/configureStore.dev.js	Integrated RTK Query reducer and middleware into development store configuration with hot module replacement support
test/utils/mountWithProviders.js	Updated redux-thunk import to use named export
test/unit/*/.test.js (30+ files)	Updated all test files to import redux-thunk as named export `{ thunk }`
tests/unit/*/.test.js (28+ files)	Updated all Jest test files to import redux-thunk as named export `{ thunk }`

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

henry-tp · 2026-02-10T22:27:35Z

+
+const getSessionToken = () => {
+  return keycloak?.token || '';
+};


The abstraction of getSessionToken() and getSessionTrace() may be a pointless exercise, but I wanted to create some level of separation such that the query call isn't calling on keycloak or tidepoolApi directly. A functional-style dependency-injection, if you will

I like this abstraction.

henry-tp · 2026-02-10T22:47:58Z

 const reducer = combineReducers({
  blip: reducers,
  router: connectRouter(history),
+  [RTKQueryApi.reducerPath]: RTKQueryApi.reducer,


This creates a new top-level redux slice called api, so it's neatly separated from all existing blip data which is nice.

henry-tp · 2026-02-11T19:38:37Z

Hi @ginnyyadav , I am tagging you in case you want to take a look (at your leisure).

The code changes for this are relatively small (<80 lines), the other ~60 file changes are just changing an import style due to breaking changes on a library upgrade for a dependency.

The changes effectively are, across 3 files:

Creating the RTK Query API object and setting it up
Shoving in the new RTK middleware
Making sure our existing middleware knows how to catch erroring requests from RTK Query

Hoping that this can help inform QA effort or help you raise any questions/concerns that should be pre-emptively addressed. As it stands, once we install RTK with this PR, nothing should change; just need to look out for any regressions. There are potential breaking changes with the dependency updates but I haven't found any issues aside from the import style.

…rors

[WEB-4390] - Install RTK - Add MSW for testing

henry-tp · 2026-02-12T19:37:56Z

@@ -1,5 +1,5 @@
 module.exports = {
-  testEnvironment: 'jsdom',
+  testEnvironment: 'jest-fixed-jsdom',


🤦🤦🤦 https://mswjs.io/docs/faq/#requestresponsetextencoder-is-not-defined-jest

We could potentially extend it ourselves instead (it's not a lot of code) if we don't want to rely yet another package.

I think it's fine to pull this in. Doing it ourselves gives us the same result with likely more maintenance.

henry-tp · 2026-02-12T19:38:29Z

  languageName: node
  linkType: hard

+"@inquirer/ansi@npm:^1.0.2":


Essentially all of this stuff is from msw

henry-tp · 2026-02-12T20:15:43Z

+};
+
+const apiHost = config.API_HOST;
+const apiVersion = 'v1';


I notice that we hardcode v1 in platform-client everywhere instead of putting it in config or something. I was thinking about putting it in config or at some higher level, but it seems like something we are intentionally not doing that

It's good here for now. Who knows if we ever will see a v2, but it's good to split the version out at any rate.

henry-tp · 2026-02-12T20:33:34Z

+  },
+});
+
+export const RTKQueryApi = createApi({


bad name?

A conventional name might be baseApi or emptySplitApi but now we have two api objects in blip.

I'd lean towards baseApi to match the filename. Any good code editor intellisense should allow us to easily find it's definition and what it does.

You're fine to leave the name as-is too. I'm fine either way.

Copilot

Pull request overview

Copilot reviewed 65 out of 67 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-13T00:19:54Z

 global.__I18N_ENABLED__ = 'false';
 global.__DEV_TOOLS__ = false;

+window.config = {


window.config is assigned a new object here, which will overwrite any existing config keys that a test (or another setup file) may have set. To avoid clobbering other settings, consider merging into the existing object (e.g., initialize window.config if missing and then set API_HOST).

Suggested change

window.config = {

window.config = {

...(window.config || {}),

I think it's fine as-is for now

Yeah, the whole window.config init makes me scratch my head every now and again, but agree it's fine.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

clintonium-119

Everything looks great to me. Nice clean work on this :)
LGTM 🚢

clintonium-119 · 2026-03-04T19:43:05Z

 const reducer = combineReducers({
  blip: reducers,
  router: connectRouter(history),
+  [RTKQueryApi.reducerPath]: RTKQueryApi.reducer,


clintonium-119 · 2026-03-04T19:48:00Z

@@ -1,5 +1,5 @@
 module.exports = {
-  testEnvironment: 'jsdom',
+  testEnvironment: 'jest-fixed-jsdom',


I think it's fine to pull this in. Doing it ourselves gives us the same result with likely more maintenance.

clintonium-119 · 2026-03-04T19:49:16Z

 global.__I18N_ENABLED__ = 'false';
 global.__DEV_TOOLS__ = false;

+window.config = {


Yeah, the whole window.config init makes me scratch my head every now and again, but agree it's fine.

clintonium-119 · 2026-03-04T20:02:33Z

+  },
+});
+
+export const RTKQueryApi = createApi({


I'd lean towards baseApi to match the filename. Any good code editor intellisense should allow us to easily find it's definition and what it does.

You're fine to leave the name as-is too. I'm fine either way.

clintonium-119 · 2026-03-04T20:03:16Z

+
+const getSessionToken = () => {
+  return keycloak?.token || '';
+};


I like this abstraction.

clintonium-119 · 2026-03-04T20:04:46Z

+};
+
+const apiHost = config.API_HOST;
+const apiVersion = 'v1';


It's good here for now. Who knows if we ever will see a v2, but it's good to split the version out at any rate.

henry-tp added 11 commits February 6, 2026 01:09

install RTK

aff5d04

resolve thunk export naming issue

185192b

use pinned version for dependencies

dc2c804

fix thunk middleware import in tests

cf3eab1

remove license warning

9bb6a50

inject x-tidepool-session-token into requests

0118546

inject trace-session token per request

28c423d

abstract out sessionTrace fetching

0f22f2f

add retry logic

84fa62a

pin reduxjs/toolkit version

fc43482

WEB-4390 empty commit for new PR

774631d

henry-tp mentioned this pull request Feb 9, 2026

Install RTK 2.11.2 #1860

Closed

1 task

henry-tp changed the title ~~WEB-4390 - Install RTK~~ [WEB-4390] - Install RTK Feb 9, 2026

henry-tp added 2 commits February 9, 2026 15:43

WEB-4390 adjust retry count to match current implementation

ea892bf

WEB-4390 bump viz

f063a1a

henry-tp marked this pull request as ready for review February 10, 2026 17:34

henry-tp added the Needs Release Target This branch cannot be merged until the feature is assigned to a release version first. label Feb 10, 2026

henry-tp mentioned this pull request Feb 10, 2026

[WEB-4390] - Install RTK - Demo (Don't Merge) #1865

Draft

henry-tp added 4 commits February 10, 2026 10:13

WEB-4390 bump retry count to 3 to match superagent

c8530ca

WEB-4390 default retry to 1 to match superagent according to docs

0305116

WEB-4390 utilize keycloak middleware for logged-out handling

f197123

WEB-4390 use redux standard actions to notify middleware

9edee02

krystophv requested a review from Copilot February 10, 2026 21:57

Copilot started reviewing on behalf of krystophv February 10, 2026 21:57 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

Comment thread app/redux/api/baseApi.js

Comment thread app/redux/api/baseApi.js Outdated

Comment thread package.json

Comment thread __tests__/unit/app/components/incrementalinput/incrementalinput.test.js Outdated

WEB-4390 abstract out getSessionToken function

99039cd

henry-tp commented Feb 10, 2026

View reviewed changes

henry-tp added 2 commits February 10, 2026 14:51

WEB-4390 remove unused import

b8e0994

WEB-4390 use reauth strategy

1c4cb40

henry-tp added 2 commits February 10, 2026 23:39

WEB-4390 use keycloak middleware for detecting 401/403 responses

23b2f40

WEB-4390 revert unneeded function

806f066

henry-tp requested a review from ginnyyadav February 11, 2026 19:36

henry-tp added 8 commits February 11, 2026 12:00

WEB-4390 use isRejected instead of isRejectedWithValue for safety

e16cb4b

WEB-4390 add refetchOnMountOrArgChange:true to prevent stale cache er…

9e93b92

…rors

WEB-4390 bump retry count to 2

fd87f47

WEB-4390 install msw and write GET test for baseApi

9063b44

WEB-4390 change test to use more idiomatic pattern for data display

401c9f0

Merge pull request #1869 from tidepool-org/WEB-4390-install-rtk-msw

8759bae

[WEB-4390] - Install RTK - Add MSW for testing

WEb-4390 add comment for RTK Query 401/403

6d139a3

WEB-4390 abstract out baseUrl for emphasis

a7a4bd5

henry-tp requested a review from krystophv February 12, 2026 19:37

henry-tp commented Feb 12, 2026

View reviewed changes

WEB-4390 improve test cases

1fde302

henry-tp mentioned this pull request Feb 12, 2026

[WEB-4390] - Install RTK tidepool-org/platform-client#215

Open

henry-tp commented Feb 12, 2026

View reviewed changes

henry-tp requested a review from clintonium-119 February 12, 2026 20:32

henry-tp commented Feb 12, 2026

View reviewed changes

krystophv requested a review from Copilot February 13, 2026 00:14

Copilot started reviewing on behalf of krystophv February 13, 2026 00:15 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

henry-tp and others added 3 commits February 16, 2026 09:33

WEB-4390 put setupStore in beforeEach

7d999c6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

WEB-4390 add beforeEach global

0bd5a58

Merge branch 'develop' into WEB-4390-install-rtk

ef1c2e4

henry-tp added the Hold for Release This branch is ready for merge, but awaiting its target release version to be the next release label Feb 18, 2026

Merge branch 'develop' into WEB-4390-install-rtk

23b2ace

clintonium-119 approved these changes Mar 4, 2026

View reviewed changes

Uh oh!

Conversation

henry-tp commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henry-tp Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henry-tp commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henry-tp Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

henry-tp Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

clintonium-119 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

henry-tp commented Feb 9, 2026 •

edited

Loading

henry-tp Feb 10, 2026 •

edited

Loading

henry-tp commented Feb 11, 2026 •

edited

Loading

henry-tp Feb 12, 2026 •

edited

Loading

henry-tp Feb 12, 2026 •

edited

Loading