Skip to content

[BUILD HOLD][LOOP-5769] Re-apply bug fix for status modal sync #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Camji55 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[BUILD HOLD][LOOP-5769] Re-apply bug fix for status modal sync #935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions Loop/Views/LoopStatusModalView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,15 +300,10 @@ class LoopStatusModalViewModel {
let timeString = ago.truncatedTimeAgoString
else { return nil }


// CI (June 2, 2026): Replace the below line with commented code below it after 510k submission is complete and build hold is lifted.

return NSLocalizedString("\(timeString) ago", comment: "last loop completed string")

// if ago > .hours(1) {
// return String(format: NSLocalizedString(">%@ ago", comment: "last loop completed string with greater than sign. (1: truncated time ago)"), timeString)
// } else {
// return String(format: NSLocalizedString("%@ ago", comment: "last loop completed string. (1: truncated time ago)"), timeString)
// }
if ago > .hours(1) {
return String(format: NSLocalizedString(">%@ ago", comment: "last loop completed string with greater than sign. (1: truncated time ago)"), timeString)
} else {
return String(format: NSLocalizedString("%@ ago", comment: "last loop completed string. (1: truncated time ago)"), timeString)
}
}
}