fix(install): bundle quickstart skill and clarify PATH activation#3
Merged
Conversation
Two issues blocked users following the README's curl-piped install path: 1. agentvfs-quickstart (start.sh, renamed) reads docs/skills/agentvfs-workspace.md relative to its own directory to write ~/.claude/skills/agentvfs-workspace/SKILL.md and ~/.codex/AGENTS.md. The release tarball didn't include this file, so every quickstart invocation outside a source checkout failed with "skill source not found". Fix: release.yml stages docs/skills/agentvfs-workspace.md into each tarball (linux/darwin-arm64/darwin-x86_64) and install.sh installs it alongside the binaries with 0644 perms. start.sh now probes $SCRIPT_DIR/docs/skills/agentvfs-workspace.md (repo mode) then $SCRIPT_DIR/agentvfs-workspace.md (installed mode) and emits a clearer multi-line error if neither is present. 2. The "Note: $PREFIX is not in your PATH" message listed two commands without indicating which was for the current shell vs which persisted for future shells. Users persisted to ~/.bashrc and then ran agentvfs-quickstart in the same session, which still had the old PATH. Fix: install.sh now prints labeled "1) Activate in the current shell (run this NOW)" and "2) Persist for future shells (run this ONCE)" steps, and suggests the rc file matching the host OS's typical login shell (zsh on macOS, bash on Linux) with the other as a one-line fallback hint. Tested: - bash -n start.sh / sh -n install.sh / yaml.safe_load on release.yml — all clean - end-to-end test of start.sh against three layouts (repo-checkout, packaged-flat, missing-skill) using a stubbed `agentvfs` binary — all three behave as expected - visual diff of the new PATH note across linux/macos with PREFIX both in and out of PATH Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two issues blocked anyone running
curl -fsSL https://raw.githubusercontent.com/thustorage/ContextFS/main/install.sh | shand thenagentvfs-quickstart:agentvfs-quickstartcouldn't find its skill source. The release tarball didn't shipdocs/skills/agentvfs-workspace.md, butstart.shreads it relative to its own directory to populate~/.claude/skills/agentvfs-workspace/SKILL.mdand~/.codex/AGENTS.md. Every invocation outside a repo checkout died withskill source not found at /home/.../.local/bin/docs/skills/agentvfs-workspace.md..github/workflows/release.ymlnow stagesdocs/skills/agentvfs-workspace.mdinto each tarball (linux / darwin-arm64 / darwin-x86_64);install.shinstalls it alongside the binaries with0644;start.shprobes$SCRIPT_DIR/docs/skills/agentvfs-workspace.mdfirst (repo mode), then$SCRIPT_DIR/agentvfs-workspace.md(installed mode), and prints a clearer multi-line error if neither exists.The "PATH is not in your PATH" note conflated "do now" with "do once". Users who ran
echo ... >> ~/.bashrc(the second line) foundagentvfs-quickstartstill missing in the current shell.install.shnow labels the two commands# 1) Activate in the current shell (run this NOW)and# 2) Persist for future shells (run this ONCE), and suggests the rc file matching the host OS's typical login shell (~/.zshrcon macOS,~/.bashrcon Linux) with the other as a one-line fallback hint.Test plan
🤖 Generated with Claude Code