Skip to content

chore: declare python dependencies#10585

Merged
wmontwe merged 2 commits intomainfrom
chore-declare-python-dependencies
Feb 25, 2026
Merged

chore: declare python dependencies#10585
wmontwe merged 2 commits intomainfrom
chore-declare-python-dependencies

Conversation

@wmontwe
Copy link
Copy Markdown
Member

@wmontwe wmontwe commented Feb 24, 2026

Resolves #10584

@wmontwe wmontwe requested a review from a team as a code owner February 24, 2026 10:43
@wmontwe wmontwe requested a review from dani-zilla February 24, 2026 10:43
@wmontwe wmontwe requested a review from coreycb February 24, 2026 11:03
@wmontwe wmontwe added the tb-team Tasks and features handled by project maintainers label Feb 24, 2026
@wmontwe wmontwe merged commit c5c48aa into main Feb 25, 2026
17 checks passed
@wmontwe wmontwe deleted the chore-declare-python-dependencies branch February 25, 2026 07:22
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 17 milestone Feb 25, 2026
Comment thread scripts/requirements.txt

# Required by: scripts/ci/setup_release_automation, scripts/ci/render-notes.py
# HTTP library for GitHub API interactions
requests==2.32.4
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will dependabot update these in the future?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a dependabot config

set -e

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
PROJECT_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is unused

echo ""
python3 -m py_compile "$SCRIPT_DIR/ci/render-notes.py" && echo " ✓ render-notes.py"
python3 -m py_compile "$SCRIPT_DIR/ci/setup_release_automation" && echo " ✓ setup_release_automation"
python3 -m py_compile "$SCRIPT_DIR/ci/merges/merge_gradle.py" && echo " ✓ merge_gradle.py"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment, not sure if we want to use set -e or not because the script will bail early on failure. Not sure if if that affects these.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, if any of these fails, there will be no cleanup

@wmontwe
Copy link
Copy Markdown
Member Author

wmontwe commented Feb 26, 2026

@coreycb I overlooked your comments, here is a fix #10612

@wmontwe wmontwe added the report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). label Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). tb-team Tasks and features handled by project maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve python related fluidattacks findings

3 participants