Skip to content

Conversation

@ol0lll
Copy link
Member

@ol0lll ol0lll commented Mar 13, 2023

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-pr-691 March 13, 2023 14:21 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-691 March 13, 2023 14:54 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-691 March 14, 2023 08:56 Inactive
"to a member function mainPropertyName() on null in media_entity_pinterest/src/Plugin/media/Source/Pinterest.php on line 155": "https://www.drupal.org/files/issues/2023-03-09/3179172.diff"
},
"drupal/media_library_media_modify": {
"Do not show grab cursor for single item": "https://git.drupalcode.org/project/media_library_media_modify/-/merge_requests/42.diff"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add patch here and use that instead of merge request diff:
https://www.drupal.org/project/thunder/issues/3309614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants