Skip to content

Conversation

@chrfritsch
Copy link
Member

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-pr-453 October 28, 2021 07:41 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-453 October 28, 2021 08:14 Inactive
@ol0lll
Copy link
Member

ol0lll commented Oct 28, 2021

  • Batch update does not work when user is selected as source
  • Paragraph is not selected
  • An entry is added to the database for each revision / linked item: table will grow fast.

@chrfritsch chrfritsch changed the base branch from 6.2.x to 8.0.x May 23, 2025 12:03
@@ -0,0 +1,30 @@
local_task_enabled_entity_types:
- media
- taxonomy_term
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding node to local_task_enabled_entity_types might be good.

local_task_enabled_entity_types:
- media
- taxonomy_term
track_enabled_source_entity_types:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add paragraphs and redirect to source entity types

- node
- taxonomy_term
- user
track_enabled_target_entity_types:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also adding paragraphs (for nested paragraphs) and redirect to distination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants