Fix square row rendering in Agents listing view#2955
Conversation
Without the autoHeight prop, the DataGrid does not receive the MuiDataGrid-root--autoHeight class, causing the data-grid-card variant's rounded row styling to not apply correctly. Fixes thunder-id#2954
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAgentsList's DataGrid component is updated to enable the ChangesDataGrid autoHeight styling
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Fixes styling/layout behavior in the Console’s Agents listing (/agents) so rows render as rounded “card” rows consistently with other listing views by enabling the DataGrid’s built-in auto-height mode (required for the MuiDataGrid-root--autoHeight class used by the data-grid-card variant).
Changes:
- Replaced
sx={{ height: 'auto' }}with theautoHeightprop onListingTable.DataGridinAgentsList.tsx.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Purpose
Fixes square-cornered row rendering in the Agents listing view (
/agents). The rows should appear as rounded cards, consistent with the Users and Groups listing views.Related Issues
Fixes #2954
Approach
AgentsList.tsxwas usingsx={{ height: 'auto' }}onListingTable.DataGridinstead of theautoHeightprop. WithoutautoHeight, the DataGrid does not receive theMuiDataGrid-root--autoHeightclass, which the oxygen-uidata-grid-cardvariant relies on for proper row sizing and rounded card styling.Changed to use
autoHeightprop, matching the established pattern inUsersList.tsxandGroupsList.tsx.Checklist
Summary by CodeRabbit