Skip to content

Fix square row rendering in Agents listing view#2955

Open
sadilchamishka wants to merge 1 commit into
thunder-id:mainfrom
sadilchamishka:fix/agents-listing-rounded-rows
Open

Fix square row rendering in Agents listing view#2955
sadilchamishka wants to merge 1 commit into
thunder-id:mainfrom
sadilchamishka:fix/agents-listing-rounded-rows

Conversation

@sadilchamishka
Copy link
Copy Markdown
Contributor

@sadilchamishka sadilchamishka commented May 21, 2026

Purpose

Fixes square-cornered row rendering in the Agents listing view (/agents). The rows should appear as rounded cards, consistent with the Users and Groups listing views.

Related Issues

Fixes #2954

Approach

AgentsList.tsx was using sx={{ height: 'auto' }} on ListingTable.DataGrid instead of the autoHeight prop. Without autoHeight, the DataGrid does not receive the MuiDataGrid-root--autoHeight class, which the oxygen-ui data-grid-card variant relies on for proper row sizing and rounded card styling.

Changed to use autoHeight prop, matching the established pattern in UsersList.tsx and GroupsList.tsx.

Checklist

  • Linked issue
  • Change is consistent with existing patterns in the codebase

Summary by CodeRabbit

  • Refactor
    • Improved agents list display by optimizing grid auto-height behavior for better layout management.

Review Change Stack

Without the autoHeight prop, the DataGrid does not receive the
MuiDataGrid-root--autoHeight class, causing the data-grid-card
variant's rounded row styling to not apply correctly.

Fixes thunder-id#2954
Copilot AI review requested due to automatic review settings May 21, 2026 17:48
@sadilchamishka sadilchamishka added Type/Bug Type/UX skip-changelog Skip generating changelog for a particular PR labels May 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6094385d-6b0d-4d8c-a257-b781f0afe8ea

📥 Commits

Reviewing files that changed from the base of the PR and between 0d4a8dd and 163f625.

📒 Files selected for processing (1)
  • frontend/apps/console/src/features/agents/components/AgentsList.tsx

📝 Walkthrough

Walkthrough

AgentsList's DataGrid component is updated to enable the autoHeight prop and removes the explicit height: 'auto' style override, aligning the rendering behavior with UsersList and GroupsList components and enabling proper rounded card row styling.

Changes

DataGrid autoHeight styling

Layer / File(s) Summary
DataGrid autoHeight prop
frontend/apps/console/src/features/agents/components/AgentsList.tsx
ListingTable.DataGrid enables the autoHeight prop and removes the explicit sx={{ height: 'auto' }} override, while cursor styling remains in sx.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix square row rendering in Agents listing view' directly describes the main change and is clear, specific, and relates to the primary issue being fixed.
Description check ✅ Passed The PR description includes Purpose, Related Issues, Approach, and Checklist sections. However, it lacks required template sections: Security checks are not completed.
Linked Issues check ✅ Passed The PR successfully addresses issue #2954 by replacing sx={{ height: 'auto' }} with the autoHeight prop on ListingTable.DataGrid, enabling proper rounded card styling.
Out of Scope Changes check ✅ Passed The change is focused and in-scope: only the autoHeight prop usage is modified in AgentsList.tsx to match UsersList.tsx and GroupsList.tsx patterns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes styling/layout behavior in the Console’s Agents listing (/agents) so rows render as rounded “card” rows consistently with other listing views by enabling the DataGrid’s built-in auto-height mode (required for the MuiDataGrid-root--autoHeight class used by the data-grid-card variant).

Changes:

  • Replaced sx={{ height: 'auto' }} with the autoHeight prop on ListingTable.DataGrid in AgentsList.tsx.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skip generating changelog for a particular PR Type/Bug Type/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agents listing view rows appear square instead of rounded

3 participants