Show "Finish" on last step of application creation wizard

[sadilchamishka]

Purpose

Fixes #2845

The final step of the application creation wizard displayed Continue instead of Finish, which was inconsistent with other resource creation flows in the console.

Changes

• ApplicationCreatePage.tsx: button label is now conditional — shows Finish when the user is on the last visible step, Continue on all preceding steps.

Proof

Note: A screen recording demonstrating the fix is attached above. The last step now correctly shows Finish.

Checklist

• Tested the fix locally across all creation flow variants (with and without optional steps like Organization Unit and Configure)
• No new dependencies introduced
• No unrelated changes included

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The application creation wizard now renders the Next button text as "finish" on the final visible step and "continue" otherwise; tests were updated to click the wizard's explicit data-testid="application-wizard-next-button".

Changes

Wizard Button Label

Layer / File(s)	Summary
Wizard button label conditional rendering frontend/apps/console/src/features/applications/pages/ApplicationCreatePage.tsx	The Next button label now conditionally renders common:actions.finish when the current visible step is the last one; otherwise displays common:actions.continue.
Tests: use explicit wizard next button test id frontend/apps/console/src/features/applications/pages/__tests__/ApplicationCreatePage.test.tsx	Multiple tests replaced clicks on the generic "Continue" button with clicks on the wizard's data-testid="application-wizard-next-button", and a new Step Navigation test verifies the label switches from Continue to Finish on the final visible step.

Sequence Diagram

sequenceDiagram
  participant ApplicationCreatePage
  participant Wizard
  participant NextButton
  ApplicationCreatePage->>Wizard: read visibleSteps & currentStep
  Wizard->>NextButton: isLastVisibleStep?
  NextButton->>NextButton: render "finish" or "continue"

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• thunder-id/thunderid#1323: Also modifies ApplicationCreatePage wizard step-navigation and final-step handling.
• thunder-id/thunderid#2659: Changes wizard step-order/visibility logic affecting last-step determination.
• thunder-id/thunderid#2365: Adds data-testid="application-wizard-next-button" targeting the same wizard control.

Suggested labels

Type/Improvement, skip-changelog

Suggested reviewers

• DonOmalVindula
• ThaminduDilshan

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: conditionally displaying 'Finish' on the last step of the application creation wizard instead of always showing 'Continue'.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The PR description covers the purpose, changes made, testing evidence, and checklist items comprehensively.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR updates the application creation wizard’s primary navigation button label so the last visible step shows “Finish” instead of “Continue”, aligning the console’s creation flows with common UX patterns.

Changes:

• Update ApplicationCreatePage to conditionally render Finish when the user is on the last visible step; otherwise Continue.

[sadilchamishka]

Addressed Copilot's comment (3271314450) in 227c77d — all last-step button clicks in ApplicationCreatePage.test.tsx now use getByTestId('application-wizard-next-button') instead of /continue/i, so the suite won't break on future label changes.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@frontend/apps/console/src/features/applications/pages/__tests__/ApplicationCreatePage.test.tsx`:
- Line 634: Before clicking the wizard CTA, add an explicit assertion that the
next button's accessible name/text is "Finish" by querying the element used in
this test (screen.getByTestId('application-wizard-next-button')) and asserting
its textContent or accessible name equals "Finish" (e.g.,
expect(screen.getByTestId('application-wizard-next-button')).toHaveTextContent(/finish/i)
) immediately before the user.click call; apply the same check for the other
instances where user.click(screen.getByTestId('application-wizard-next-button'))
appears in this test file to ensure the final-step CTA label is verified across
all cases.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8eb09025-5196-44c8-b568-4d5ca63f137c

📥 Commits

Reviewing files that changed from the base of the PR and between 227c77d and dfb6551.

📒 Files selected for processing (2)

• frontend/apps/console/src/features/applications/pages/ApplicationCreatePage.tsx
• frontend/apps/console/src/features/applications/pages/__tests__/ApplicationCreatePage.test.tsx

[sadilchamishka]

Addressed both review comments (Copilot thread PRRT_kwDOOi7AYc6DXvCb and CodeRabbit thread PRRT_kwDOOi7AYc6DXvWT) in f472df1.

Added a focused test in the Step Navigation block that uses the backend flow (2 visible steps: STACK → NAME):

• Asserts the next button reads Continue on STACK (non-last step)
• Asserts the next button reads Finish on NAME (last visible step)

This pins the label-switching behaviour without coupling every existing test to the button text.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!