Skip to content

Fix GitHub instance action workflow#957

Merged
hjiangsu merged 17 commits intodevelopfrom
misc/github-instance-action
Dec 5, 2023
Merged

Fix GitHub instance action workflow#957
hjiangsu merged 17 commits intodevelopfrom
misc/github-instance-action

Conversation

@hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Dec 5, 2023

Pull Request Description

This PR fixes some of the issues with the instance workflow from #905. It also adds some more logic to help format the output properly.

This is the result of the workflow: https://github.com/thunder-app/thunder/pull/956/files

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@hjiangsu hjiangsu merged commit 3502aac into develop Dec 5, 2023
@hjiangsu hjiangsu deleted the misc/github-instance-action branch December 5, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments