Conversation
Co-authored-by: William <sirwilliamthefirst@users.noreply.github.com>
hjiangsu
reviewed
Nov 18, 2024
Member
hjiangsu
left a comment
There was a problem hiding this comment.
Thanks for starting work on the v0.20.x changes! I just made a quick comment for how to approach any newly added values in the API. Let me know if you need further guidance on adding/removing fields.
Member
|
I just committed a couple of things:
Aside from that, I believe this looks good to me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a good amount of updates to the lemmy v0.20.0 API. This PR fixes the ones that are required to run with v0.20.0 and to support OAuth/SSO. There may be additional api changes also.
LemmyNet/lemmy@0.19.6...main
LemmyNet/lemmy-js-client@0.19.6...0.20.0-alpha.18
Some v0.20.0 api changes that I see so far:
I am following this blog post from @privacyguard to implement the SSO
https://privacyportal.org/blog/sign-in-with-privacy-portal-tutorial