feat: add support for configurable histogram buckets#22
Open
jcord04 wants to merge 1 commit intothumbor-community:masterfrom
Open
feat: add support for configurable histogram buckets#22jcord04 wants to merge 1 commit intothumbor-community:masterfrom
jcord04 wants to merge 1 commit intothumbor-community:masterfrom
Conversation
Add opt-in histogram metrics with configurable bucket boundaries to enable accurate percentile calculations (p50, p95, p99) for latency monitoring. Changes: - Add PROMETHEUS_USE_HISTOGRAMS config option (default: False for backwards compatibility) - Add PROMETHEUS_LATENCY_BUCKETS config for customizable bucket boundaries - Convert timing values from milliseconds to seconds per Prometheus best practices - Update metrics implementation to support both Summary and Histogram modes - Add comprehensive test coverage for histogram functionality - Update documentation with migration guide and usage examples Default buckets: [0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0, 10.0, 30.0, 60.0] seconds Maintains full backwards compatibility - existing installations continue using Summary metrics unless explicitly opted-in to histograms. Resolves: Feature request for configurable latency histogram buckets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add opt-in histogram metrics with configurable bucket boundaries to enable accurate percentile calculations (p50, p95, p99) for latency monitoring.
Changes:
Default buckets: [0.05, 0.1, 0.25, 0.5, 1.0, 2.5, 5.0, 10.0, 30.0, 60.0] seconds
Maintains full backwards compatibility - existing installations continue using Summary metrics unless explicitly opted-in to histograms.
Resolves: Feature request for configurable latency histogram buckets