Skip to content

chore(ethereum/test): read mainnet RPC URL from env, drop hardcoded key #3997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piotr-roslaniec wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(ethereum/test): read mainnet RPC URL from env, drop hardcoded key #3997

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
531270a
chore(ethereum/test): read mainnet RPC URL from env, drop hardcoded key
piotr-roslaniec May 24, 2026
72a8af8
chore(ethereum/test): use ETHEREUM_MAINNET_RPC_URL env var
piotr-roslaniec May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion pkg/chain/ethereum/ethereum_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package ethereum

import (
"fmt"
"os"
"reflect"
"testing"
"time"
Expand All @@ -17,9 +18,26 @@ import (
// TODO: Include integration test in the CI.
// To run the tests execute `go test -v -tags=integration ./...`

const ethereumURL = "https://mainnet.infura.io/v3/f41c6e3d505d44c182a5e5adefdaa43f"
// ethereumURLEnvVar is the name of the env variable holding the Ethereum
// mainnet JSON-RPC endpoint used by this integration test. The test asserts
// against well-known historical block numbers on mainnet, so the URL MUST
// point to mainnet (not a testnet) or assertions will silently fail.
//
// The previous hardcoded Infura URL was checked into the repository and
// must be treated as compromised; rotate the key on the provider side and
// inject the new URL via this env variable (matches the existing org
// secret name).
const ethereumURLEnvVar = "ETHEREUM_MAINNET_RPC_URL"

func TestBaseChain_GetBlockNumberByTimestamp(t *testing.T) {
ethereumURL := os.Getenv(ethereumURLEnvVar)
if ethereumURL == "" {
t.Skipf(
"skipping: env variable [%s] with Ethereum mainnet JSON-RPC URL is not set",
ethereumURLEnvVar,
)
}

client, err := ethclient.Dial(ethereumURL)
if err != nil {
t.Fatal(err)
Expand Down
Loading