Skip to content

SCAL-315472 TSE css styling and action for referencing#548

Open
adityabhushan-pixel wants to merge 1 commit into
mainfrom
SCAL-315472
Open

SCAL-315472 TSE css styling and action for referencing#548
adityabhushan-pixel wants to merge 1 commit into
mainfrom
SCAL-315472

Conversation

@adityabhushan-pixel
Copy link
Copy Markdown

No description provided.

@adityabhushan-pixel adityabhushan-pixel requested a review from a team as a code owner June 2, 2026 06:54
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the reference-mode toggle button in the SpotterViz chat input by adding the 'SpotterVizReferenceMode' action to the 'Action' enum and defining three new CSS variables for styling. The reviewer suggested renaming the CSS variables to use the '--ts-var-spotterviz-reference-' prefix instead of '--ts-var-liveboard-reference-' to maintain consistency with existing SpotterViz variables and the action name.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/css-variables.ts
Comment on lines +1169 to +1187
/**
* Background color of the reference-mode toggle button in the SpotterViz
* chat input when it is unselected and the user hovers over it.
*/
'--ts-var-liveboard-reference-icon-hover-background'?: string;

/**
* Icon (glyph) color for the reference-mode selected state — applies to
* both the toggle button when active and the icon badge on each
* referenced-entity chip in the chat input.
*/
'--ts-var-liveboard-reference-selected-icon-color'?: string;

/**
* Background color for the reference-mode selected state — applies to
* both the toggle button when active and the icon badge on each
* referenced-entity chip in the chat input.
*/
'--ts-var-liveboard-reference-selected-background'?: string;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with other SpotterViz CSS variables (which are all prefixed with --ts-var-spotterviz-) and the action name SpotterVizReferenceMode, these new variables should be prefixed with --ts-var-spotterviz-reference- instead of --ts-var-liveboard-reference-.

Suggested change
/**
* Background color of the reference-mode toggle button in the SpotterViz
* chat input when it is unselected and the user hovers over it.
*/
'--ts-var-liveboard-reference-icon-hover-background'?: string;
/**
* Icon (glyph) color for the reference-mode selected state applies to
* both the toggle button when active and the icon badge on each
* referenced-entity chip in the chat input.
*/
'--ts-var-liveboard-reference-selected-icon-color'?: string;
/**
* Background color for the reference-mode selected state applies to
* both the toggle button when active and the icon badge on each
* referenced-entity chip in the chat input.
*/
'--ts-var-liveboard-reference-selected-background'?: string;
/**
* Background color of the reference-mode toggle button in the SpotterViz
* chat input when it is unselected and the user hovers over it.
*/
'--ts-var-spotterviz-reference-icon-hover-background'?: string;
/**
* Icon (glyph) color for the reference-mode selected state applies to
* both the toggle button when active and the icon badge on each
* referenced-entity chip in the chat input.
*/
'--ts-var-spotterviz-reference-selected-icon-color'?: string;
/**
* Background color for the reference-mode selected state applies to
* both the toggle button when active and the icon badge on each
* referenced-entity chip in the chat input.
*/
'--ts-var-spotterviz-reference-selected-background'?: string;
References
  1. When adding new code, prioritize maintaining local consistency with existing patterns in the file over introducing a new, more concise pattern if it breaks from the established convention.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 2, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@548

commit: 16f8369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant