SCAL-315058: isReadyForRenderPromise gate never resolves + null-safety in init path

src/embed/auto-frame-renderer.ts

@@ -146,8 +146,12 @@ class AutoFrameRenderer extends TsEmbed {
      */
     public async replaceIframe(iframe: HTMLIFrameElement): Promise<void> {
         this.frameToReplace = iframe;
+        if (this.shouldWaitForRenderPromise) {
+            await this.isReadyForRenderPromise;
+        }
         const src = this.getMCPIframeSrc(iframe.src);
         await this.renderIFrame(src);
+        this.isRendered = true;
     }
 }
 

src/embed/base.spec.ts

@@ -10,7 +10,7 @@ import * as base from './base';
 import * as embedConfigInstance from './embedConfig';
 import * as resetService from '../utils/resetServices';
 import * as processTrigger from '../utils/processTrigger';
-import { createAndSetInitPromise, getInitPromise, getIsInitCalled, reloadIframe } from './base';
+import { createAndSetInitPromise, getInitPromise, getIsInitCalled, getIsInitCompleted, reloadIframe } from './base';
 
 import {
     executeAfterWait,
@@ -607,4 +607,28 @@ describe('Init Promise Functions', () => {
         const secondPromise = getInitPromise();
         expect(firstPromise).toBe(secondPromise);
     });
+
+    test('getIsInitCompleted returns false (not undefined) before init resolves', () => {
+        // fresh store via beforeEach; init not yet called
+        const result = getIsInitCompleted();
+        expect(result).toBe(false);
+        expect(typeof result).toBe('boolean');
+    });
+
+    test('getIsInitCompleted returns true after init resolves', async () => {
+        base.init({
+            thoughtSpotHost: 'tshost',
+            authType: index.AuthType.None,
+        });
+        await getInitPromise();
+        // flush the finally() microtask
+        await new Promise((r) => setTimeout(r, 0));
+        expect(getIsInitCompleted()).toBe(true);
+    });
+
+    test('getIsInitCompleted returns false when window store is absent', () => {
+        // clear the store from window
+        (window as any)._tsEmbedSDK = {};
+        expect(getIsInitCompleted()).toBe(false);
+    });
 });

src/embed/base.ts

@@ -209,6 +209,10 @@ export const createAndSetInitPromise = (): void => {
     });
     initPromise.finally(() => {
         const curVal = getValueFromWindow<InitFlagStore>(initFlagKey);
+        if (!curVal) {
+            logger.error('initFlagStore missing when marking init complete');
+            return;
+        }
         curVal.isInitCompleted = true;
         storeValueInWindow(initFlagKey, curVal);
     });
@@ -221,8 +225,8 @@ export const getInitPromise = ():
         ReturnType<typeof init>
     > => getValueFromWindow<InitFlagStore>(initFlagKey)?.initPromise;
 
-export const getIsInitCompleted = (): boolean => 
-    getValueFromWindow<InitFlagStore>(initFlagKey)?.isInitCompleted;
+export const getIsInitCompleted = (): boolean =>
+    !!getValueFromWindow<InitFlagStore>(initFlagKey)?.isInitCompleted;
 
 export const getIsInitCalled = (): boolean => !!getValueFromWindow(initFlagKey)?.isInitCalled;