Tb wf test

[ruchI9897]

No description provided.

[mnk-blr]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[sonar-prod-ts]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.5% Duplication

[gemini-code-assist]

Summary of Changes

Hello @ruchI9897, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the ThoughtSpot Visual Embed SDK by introducing a powerful API interception feature, allowing developers to programmatically manage network requests within embedded content. Complementing this, the SDK's lifecycle management has been refined, offering more control over embed destruction and pre-rendering. A suite of new configuration flags has been added to enable deeper customization of the embedded UI and features, alongside improvements to authentication token validation and the TypeScript build process. These updates collectively aim to provide a more flexible, robust, and customizable embedding experience.

Highlights

• API Interception Feature: Introduced a new capability to intercept and modify API calls within embedded ThoughtSpot applications, providing fine-grained control over data requests and responses. This includes new types, utility functions, and integration into the core embed logic.
• Enhanced Embed Lifecycle Management: Improved the embed destruction process with options to wait for cleanup completion and specify a timeout. The pre-rendering mechanism was also enhanced to support replacing existing pre-renders and dynamically updating embed parameters.
• New Configuration Options: Added several new flags across AppEmbed and LiveboardEmbed, such as hideTagFilterChips, isLinkParametersEnabled, isCentralizedLiveboardFilterUXEnabled, isEnhancedFilterInteractivityEnabled, enablePastConversationsSidebar, and showSpotterLimitations, offering greater control over UI elements and feature behavior.
• Improved Authentication Token Validation: Strengthened the authentication token validation by explicitly checking for string types, preventing potential errors from non-string inputs.
• TypeScript Declaration Bundling Update: Migrated the TypeScript declaration file generation process from dts-bundle to dts-bundle-generator, improving the efficiency and robustness of type definition bundling.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant number of improvements and new features. The refactoring of the API interception logic is a major step forward, providing a more flexible and powerful way to interact with the SDK. The updates to the build system, addition of new embed flags, and improvements to the destroy and pre-rendering logic are all valuable changes that enhance the SDK's capabilities and robustness.

I've left a few comments regarding potential breaking changes, mainly around the removal of a legacy flag from type definitions and the removal of some CSS variables. It would be great to get some clarification on these points to ensure a smooth transition for users of the SDK.

Overall, this is a very solid set of changes. Great work!