Skip to content

chore: Sync gemfiles with updated Appraisals configuration#550

Open
toshimaru wants to merge 5 commits intothoughtbot:mainfrom
toshimaru:regenerate-gemfiles
Open

chore: Sync gemfiles with updated Appraisals configuration#550
toshimaru wants to merge 5 commits intothoughtbot:mainfrom
toshimaru:regenerate-gemfiles

Conversation

@toshimaru
Copy link
Contributor

Context

The generated gemfiles/*.gemfile files had drifted out of sync with the Appraisals file. This PR cleans up the Appraisals configuration and regenerates all gemfiles.

Changes

  • Update Appraisals to add/remove gems as needed
  • Regenerate gemfiles/*.gemfile with bundle exec appraisal

Copilot AI review requested due to automatic review settings January 1, 2026 04:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR synchronizes the generated gemfiles with an updated Appraisals configuration, removing unnecessary development/testing dependencies from the appraisal blocks and ensuring consistency across different Rails versions.

  • Cleaned up the Appraisals file by removing global development dependencies (appraisal, aruba, cucumber, rake, rspec-rails, standard) that shouldn't be in version-specific blocks
  • Removed deprecated dependencies (spring-watcher-listen) and version-specific gems that are no longer needed
  • Added version-appropriate gems for newer Rails versions (e.g., solid_cache for Rails 8.0)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Appraisals Updated configuration for all Rails versions (6.1, 7.0, 7.1, 7.2, 8.0), removing unnecessary dev/test gems and adding version-specific dependencies
gemfiles/rails6.1.gemfile Regenerated to match updated Appraisals configuration, removing global dev dependencies
gemfiles/rails7.0.gemfile Regenerated to match updated Appraisals configuration, removing unnecessary gems like drb, listen, spring, and bigdecimal
gemfiles/rails7.1.gemfile Regenerated to match updated Appraisals configuration, adding error_highlight and rubocop-rails-omakase
gemfiles/rails7.2.gemfile Regenerated to match updated Appraisals configuration, removing listen and spring dependencies, adding brakeman and rubocop
gemfiles/rails8.0.gemfile Regenerated to match updated Appraisals configuration, adding Rails 8-specific gems (bcrypt, solid_cache, thruster)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

end

appraise "rails8.0" do
gem "bcrypt"
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bcrypt gem is specified without a version constraint in the Appraisals file, but the removed line shows it previously had a constraint of "~> 3.1.7". Consider whether a version constraint should be maintained for bcrypt to ensure compatibility and avoid unexpected breaking changes in the future.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant