Include Migration.new in the transaction block#5
Merged
MatheusRich merged 3 commits intomainfrom Feb 3, 2026
Merged
Conversation
Move the transaction from the instance `run` method to `self.run` so it wraps both initialization and execution. This ensures database operations in `initialize` are rolled back on failure. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MatheusRich
force-pushed
the
fix-transaction-wrap-initialize
branch
3 times, most recently
from
68872aa to
c719b04
Compare
MatheusRich
force-pushed
the
fix-transaction-wrap-initialize
branch
from
c719b04 to
f0ba29e
Compare
MatheusRich
changed the title
Migration.new in the transaction block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Move transaction from instance
runtoself.runto wrap bothnew(...)and.run.Database operations in
initializeare now rolled back on failure.