This repository was archived by the owner on Jun 21, 2019. It is now read-only.
Add support for comma-separated titles in prospect command.#23
Open
siadat wants to merge 1 commit intothoughtbot:masterfrom
Open
Add support for comma-separated titles in prospect command.#23siadat wants to merge 1 commit intothoughtbot:masterfrom
siadat wants to merge 1 commit intothoughtbot:masterfrom
Conversation
cmd/clearbit/prospect.go
Outdated
| titlesCSV = ctx.StringSlice("title") | ||
| ) | ||
|
|
||
| titles := make([]string, 0) |
There was a problem hiding this comment.
can probably use "var titles []string" instead
Contributor
|
I like the idea! Could use a spec? Should it also support ", " (space after comma)? |
Example usage:
clearbit prospect -title CEO,COO company.com
clearbit prospect -title "CEO, COO" -title CTO company.com
Closes thoughtbot#17
Author
I think so. I just updated the commit so spaces before and after comma are ignored. E.g.: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example usage:
Closes #17