split show template

[goosys]

• refs Split Templates for Improved Customizability #2823

[goosys]

Memo (just thinking out loud)

• local_assigns feels too loose — maybe we should pass only the required locals?
• The partial file names probably need another look.
  • We'll be doing similar work in form/index, so it might be better to align the naming.

[nickcharlton]

Now some time has passed, do you have any more toughts on the local_assigns and partials naming?

[goosys]

It’s been a while, and I’m a bit fuzzy on what the original concern was, but looking at it again, both options seem fine to me.

If there are no concerns about the approach of splitting show, I can go ahead and split index and form in the same way and put together a draft PR. Then we can review those and make a final decision based on that -- what do you think?

[nickcharlton]

Yeah, sounds like a good plan.

Re: local_assigns, I think we just want to ensure we don't inadvertently leak lots of context into a page, but we also don't want to make people's job overriding stuff harder unnecessarily.