Skip to content

add load_defaults option to example_app#2949

Open
goosys wants to merge 2 commits intothoughtbot:mainfrom
goosys:fix/load_defaults
Open

add load_defaults option to example_app#2949
goosys wants to merge 2 commits intothoughtbot:mainfrom
goosys:fix/load_defaults

Conversation

@goosys
Copy link
Copy Markdown
Contributor

@goosys goosys commented Dec 3, 2025

To ensure tests run correctly on each Rails version, I think it's better to set load_defaults accordingly.

I tried setting it, but it resulted in a large number of errors. I plan to fix them gradually over time.
Once all errors are resolved, I will open a PR.

If you have any concerns or a different direction in mind, please let me know.

@goosys goosys marked this pull request as draft December 3, 2025 02:58
@goosys goosys force-pushed the fix/load_defaults branch from 8296493 to 8aff034 Compare December 3, 2025 15:23
@goosys goosys changed the title WIP: add load_defaults option to example_app add load_defaults option to example_app Dec 3, 2025
@goosys
Copy link
Copy Markdown
Contributor Author

goosys commented Feb 20, 2026

@nickcharlton nickcharlton added the dependencies changes or issues relating to a dependency label Mar 25, 2026
@goosys goosys force-pushed the fix/load_defaults branch from 8aff034 to 28c4191 Compare March 26, 2026 10:10
@goosys goosys marked this pull request as ready for review March 26, 2026 10:18
@goosys
Copy link
Copy Markdown
Contributor Author

goosys commented Mar 26, 2026

@nickcharlton

  • Enabled load_defaults to be set per Rails version
  • Removed configuration values set by load_defaults from config/application.rb
    • This eliminates the warnings that were appearing at runtime
    • DEPRECATION WARNING: `config.active_support.to_time_preserves_timezone` is 
      deprecated and will be removed in Rails 8.2 (called from <top (required)> at 
      /workspaces/administrate/spec/example_app/config/environment.rb:5)
      
  • Fixed the issues that were causing errors

@goosys goosys force-pushed the fix/load_defaults branch from 2a49240 to b502e94 Compare March 26, 2026 11:30
@goosys goosys force-pushed the fix/load_defaults branch from 37fa665 to 198f6cf Compare March 26, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies changes or issues relating to a dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants