Skip to content

Add some debug logs in flair. #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fische wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add some debug logs in flair. #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5bd55b
Add some debug logs in flair.
fische Sep 23, 2024
70cbee3
Bump version to 11.11.2.
fische Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Version 11.11.2
---------------
* Add some debug logs to flair.

Version 11.11.1
---------------
* Add keepalive config to gRPC dial parameters
Expand Down
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
11.11.1
11.11.2
4 changes: 4 additions & 0 deletions flair/rpc/rpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ func (s *server) GetCapabilities(ctx context.Context, req *pb.GetCapabilitiesReq
}

func (s *server) GetActionResult(ctx context.Context, req *pb.GetActionResultRequest) (ar *pb.ActionResult, err error) {
log.Debugf("received GetActionResultRequest for %+v", req.GetActionDigest())
err = s.replicator.SequentialDigest(req.ActionDigest, func(srv *trie.Server) error {
ctx, cancel := context.WithTimeout(ctx, s.timeout)
defer cancel()
Expand Down Expand Up @@ -275,6 +276,7 @@ func (s *server) BatchUpdateBlobs(ctx context.Context, req *pb.BatchUpdateBlobsR
}

func (s *server) BatchReadBlobs(ctx context.Context, req *pb.BatchReadBlobsRequest) (*pb.BatchReadBlobsResponse, error) {
log.Debugf("received BatchReadBlobsRequest for %+v", req.GetDigests())
blobs := map[*trie.Server][]*pb.Digest{}
for _, d := range req.Digests {
s := s.replicator.Trie.Get(d.Hash)
Expand Down Expand Up @@ -402,6 +404,7 @@ func (s *server) GetTree(req *pb.GetTreeRequest, srv pb.ContentAddressableStorag
}

func (s *server) Read(req *bs.ReadRequest, srv bs.ByteStream_ReadServer) error {
log.Debugf("received ReadRequest for %+v", req.GetResourceName())
hash, err := s.bytestreamBlobName(req.ResourceName)
if err != nil {
return err
Expand Down Expand Up @@ -565,6 +568,7 @@ func (s *server) assetHash(quals []*apb.Qualifier) string {
}

func (s *server) Execute(req *pb.ExecuteRequest, stream pb.Execution_ExecuteServer) error {
log.Debugf("received ExecuteRequest for %+v", req.GetActionDigest())
return s.exeReplicator.SequentialDigest(req.ActionDigest, func(srv *trie.Server) error {
client, err := srv.Exe.Execute(s.forwardMetadata(stream.Context()), req)
if err != nil {
Expand Down