Skip to content

Conversation

@MillicentAmolo
Copy link

Description
Added forgot/reset password functionality to the application. This includes new components for handling password recovery and updates to existing authentication and state management files to integrate the feature.

Fixes # (issue)
Implement forgot/reset password feature

Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Created new forgot-password and reset-password components.
Updated authentication.service.ts to handle password reset requests.
Updated routing in doubtfire.states.ts to include forgot/reset password states.
Confirmed navigation between login, forgot password, and reset password flows works correctly.
Testing Checklist:
Tested in latest Chrome
Tested in latest Firefox
Checklist:
[x ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
[ x] I have commented my code in hard-to-understand areas
I have made corresponding changes to the documentation
[x ] My changes generate no new warnings
I have requested a review from @macite and @jakerenzella on the Pull Request

@AB-Deakin
Copy link

419branch
Merging branch needs to be updated to 9.x not development

@MillicentAmolo MillicentAmolo changed the base branch from development to 9.x September 18, 2025 13:13
Copy link

@AB-Deakin AB-Deakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ran tests on the frontend changest and it is working correctly and code looks good. With these changes coming off the development branch instead of 9.x it may cause some issues as well. May need to check with the senior team if it can merge as is or if it needs to be branched off of the 9.x branch like the API PR. But everything else works and looks good from my testing.
test1
test2

Copy link

@ibi420 ibi420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MillicentAmolo , great work on this. I can confirm the functionality works as expected. Despite the earlier issue with creating the function on the development branch instead of 9.x, everything now runs smoothly without errors. You’ve adhered to the TypeScript migration pattern and made good use of modern Angular components. The UI is consistent with OnTrack’s look and feel. Excellent job on this.

@EkamBhullar
Copy link

Great work on this PR, @MillicentAmolo. I pulled the branch down and tested the new forgot/reset password flow. Functionality works as expected across both Chrome and Firefox, navigation between login, forgot password, and reset password is smooth and error-free.

From a technical standpoint, you’ve followed the TypeScript migration pattern well and used modern Angular components cleanly. The UI is consistent with OnTrack’s design language, and your updates to the authentication service and routing are easy to follow. Code readability is strong, with comments in the right places. Nice Job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants