Skip to content

Conversation

@lachlan-robinson
Copy link

Description

Migration of the achievement-custom-bar-chart component in the 9.x branch.

Includes update to the package.json for various d3 modules necessary for creating the custom graph.

IMPORTANT: This migration is branched from the pending migration of the outcome service: #390

Type of change

  • Component Migration

How Has This Been Tested?

  • Data displays accurately (Tested alongside old component to ensure consistency)
  • Style matches that of the previous component.
  • Tool-tips are styled consistently with the previous component.
  • Hover effects are functional.

Before:

BeforeChart

After:

AfterChart

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link

@Pasindufdo98 Pasindufdo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Lachalan nice work on this feature. I was able to successfully build without any build errors. The chart looks clean, and the tooltips are a great touch. The only thing I noticed is that there’s a console error (Cannot read properties of undefined (reading 'selectAll')). It might be worth adding a quick null/undefined check before calling selectAll in renderChart() just to avoid that runtime issue. Other than that, everything looks solid!

Screenshot (1902) Screenshot (1903)

@returnMarcco
Copy link

returnMarcco commented Sep 16, 2025

Hey @lachlan-robinson,

Good work on the migration. No obvious console or API errors. The template has been ported to Angular Material. The graph itself looks good. Tooltips are a welcome feature.

The only suggestion I can make is to do with performance. Currently, it seems that the tooltip updates on mouse move. This slows down when moving the mouse a lot. I'd suggest anchoring the tooltip to the part of the graph that is being hovered over and rendering it once onmouseenter. This is just a nitpick though.

Approving this, great work.

Copy link

@Pasindufdo98 Pasindufdo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Good work!

Copy link

@disururathnayake disururathnayake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lachlan-robinson ,
Great job on the migration! I didn’t spot any console or API errors and the graph looks good. The addition of tooltips is a nice touch too. Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants