-
Notifications
You must be signed in to change notification settings - Fork 137
feat: enhance search in courseflow with autocomplete and remove #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: new/course-flow
Are you sure you want to change the base?
feat: enhance search in courseflow with autocomplete and remove #409
Conversation
Duy-Nguyen1104
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Josh. I have fetched your PRs and tested out the behavior regarding searching for unit. Here are the improvements that I confirmed:
- When I search for a unit, the text I enter is used as a filter to find the exact match.
- As I type, a filtered list appears above the search bar.
- I can search using both the code and unit title
Everything is working smoothly. As a future enhancement, we could make the filter more fine-grained (e.g., by level or campus). Overall, great work!
AB-Deakin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hi @Lolretrorat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The courseflow unit search works smooth — autocomplete updates live as I type, and removing units from the list is clean with no weird side effects. I tested add/remove, fast typing, and empty state; no regressions. Maybe just add a small debounce to cut extra calls and a quick test for remove + no-match case.








Description
Added enhancement to courseflow unit search including autocomplete of available units that dynamically updates as input updates.
Also added remove units from list functionality
Fixes # (issue)
Type of change
How Has This Been Tested?
AS an admin
IF i input text into a search field
THEN i should see autocomplete suggestions
AND selecting an option should add the unit to the required/elective unit list
AND furhter autocomplete suggestions should not include the unit again
Input sanitization was also verified
Testing Checklist:
Checklist: