Skip to content

Conversation

@Pasindufdo98
Copy link

@Pasindufdo98 Pasindufdo98 commented Sep 1, 2025

Description

This PR fixes multiple issues in the 9.x branch:

  • Clicking Tasks in the unit dropdown menu now correctly loads the Task Viewer component. Previously, the button appeared unresponsive and the route was not updating.
  • Fixed the task list panel so it scrolls independently as expected.
  • Resolved an issue with the PDF viewer not displaying correctly.

After fixing routing issue.
Screenshot (1778)

After fixing both routing and UI issues.
image

Type of change

  • Corrected the UI-Router state configuration to properly register the units/tasks/viewer state.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Ensured that the TaskViewerStateComponent is linked to the correct parent state (unit-root-state).
  • Manually tested navigation to /units/:id/tasks/viewer while logged in as a Convenor, and confirmed it now loads the Task Viewer correctly instead of redirecting to the home page.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Pasindufdo98 Pasindufdo98 marked this pull request as ready for review September 2, 2025 17:34
Copy link

@returnMarcco returnMarcco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Pasindufdo98,

Good work on this fix.

The component routes as expected. I've left a suggestion on where to keep the state declaration, but other than that, everything looks good.

Once the feedback is reviewed and requested changes are made I'll approve this PR.

Cheers.

Copy link

@returnMarcco returnMarcco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving this.

Copy link

@chelaz1234 chelaz1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Pasindufdo98,
The PR description is clear and well-scoped: it explains what was broken (task viewer routing, task list scrolling, PDF viewer) and what was fixed. The routing fix has been properly implemented and works as expected. Overall, great job!

Copy link

@HasinduWelarathne HasinduWelarathne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Pasindufdo98 ,
Tested the routing changes and everything works as expected. The task viewer now loads correctly without navigation issues. Code looks clean and aligns well with the existing Angular structure. Great job on fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants