-
Notifications
You must be signed in to change notification settings - Fork 137
Fix task viewer routing #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.x
Are you sure you want to change the base?
Conversation
returnMarcco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Pasindufdo98,
Good work on this fix.
The component routes as expected. I've left a suggestion on where to keep the state declaration, but other than that, everything looks good.
Once the feedback is reviewed and requested changes are made I'll approve this PR.
Cheers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving this.
chelaz1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Pasindufdo98,
The PR description is clear and well-scoped: it explains what was broken (task viewer routing, task list scrolling, PDF viewer) and what was fixed. The routing fix has been properly implemented and works as expected. Overall, great job!
HasinduWelarathne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Pasindufdo98 ,
Tested the routing changes and everything works as expected. The task viewer now loads correctly without navigation issues. Code looks clean and aligns well with the existing Angular structure. Great job on fixing this!
Description
This PR fixes multiple issues in the 9.x branch:
After fixing routing issue.

After fixing both routing and UI issues.

Type of change
Corrected the UI-Router state configuration to properly register the units/tasks/viewer state.
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Testing Checklist:
Checklist: