-
Notifications
You must be signed in to change notification settings - Fork 137
feat: migrate portfolio-review-step #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.x
Are you sure you want to change the base?
feat: migrate portfolio-review-step #401
Conversation
…view-step.component.scss
Triet-coder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Looks great. I have tested this migration, and it works perfectly fine. You can just try including some screenshots, so it is easy to compare |
|
Hi @EkamBhullar, I’ve added screenshots showing the before and after states of the migration. You can now compare them side by side. |
HasinduWelarathne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.




Any italic text should be deleted from the final Pull Request text, including this line
Description
This component is allows students to review their selected tasks and learning summary report before final submission. It checks for required components like task selection and ILO alignment, displays warnings if anything is missing, and lets students confirm their portfolio is ready for assessment._
Type of change
Migrated: portfolio-review-step.coffee →portfolio-review-step.component.ts, .html, .scss
Deleted: portfolio-review-step.coffee,portfolio-review-step.tpl.html
Updated: doubtfire-angularjs.module.ts (removed old directive reference)
Updated: portfolio.tpl.html to mount the new Angular 17 component
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Before:

After:


Checklist: