Skip to content

Conversation

@rashi-agrawal29
Copy link

@rashi-agrawal29 rashi-agrawal29 commented Aug 25, 2025

Description

This task migrates the unit-ilo-edit-modal component from CoffeeScript to TypeScript. This modal is used to add or edit learning outcomes that correspond to each unit, using OutcomeLearningService to associate it with a certain unit ID. The modal displays the title of the ILO, the abbreviation, and its description.

Type of change

Frontend Migration

How Has This Been Tested?

  • Log in as aadmin.
  • Go to the Admin settings and then select the Manage Units option.
  • Select any unit and go to Learning Outcomes tab.
  • Either press the Add Outcome button or any pre-existing ILO. The former will create a blank ILO and the latter will display the ILO data.
  • Click on save or create and the Learning Outcomes list should update itself.

Screenshots

Before:

image image

After:

image image

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@rashi-agrawal29 rashi-agrawal29 changed the title Migrate Unit ilo Modal Migrate Unit ilo Edit Modal Aug 25, 2025
@rashi-agrawal29 rashi-agrawal29 marked this pull request as ready for review August 25, 2025 05:18
Copy link

@lachlan-robinson lachlan-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rashi-agrawal29, this migration has been completed well, there is just a minor change required before approval.

  • The styling is consistent with the previous implementation of the component.
  • The component is functional and successfully handled errors such as duplicate ABBR.
  • The reference to modals.coffee needs to be removed from doubtfire-angularjs.module.ts as the file no longer exists.

@rashi-agrawal29 rashi-agrawal29 force-pushed the migrate/unit-ilo-edit-modal branch from 8da5d55 to 987f1e1 Compare August 31, 2025 11:24
Copy link

@lachlan-robinson lachlan-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WaelAlahamdi
Copy link

Hi @rashi-agrawal29,
I tested the migrated unit-ilo-edit-modal on my local setup. Creating and editing ILOs worked correctly, and the outcomes list updated as expected. I didn’t encounter any issues. Approved from my side.
Great work!

@rashi-agrawal29
Copy link
Author

Hi @rashi-agrawal29, I tested the migrated unit-ilo-edit-modal on my local setup. Creating and editing ILOs worked correctly, and the outcomes list updated as expected. I didn’t encounter any issues. Approved from my side. Great work!

Thank you @WaelAlahamdi really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants