-
Notifications
You must be signed in to change notification settings - Fork 137
Migrate Unit ilo Edit Modal #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.x
Are you sure you want to change the base?
Migrate Unit ilo Edit Modal #400
Conversation
lachlan-robinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rashi-agrawal29, this migration has been completed well, there is just a minor change required before approval.
- The styling is consistent with the previous implementation of the component.
- The component is functional and successfully handled errors such as duplicate ABBR.
- The reference to
modals.coffeeneeds to be removed fromdoubtfire-angularjs.module.tsas the file no longer exists.
8da5d55 to
987f1e1
Compare
lachlan-robinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hi @rashi-agrawal29, |
Thank you @WaelAlahamdi really appreciate it! |
Description
This task migrates the
unit-ilo-edit-modalcomponent from CoffeeScript to TypeScript. This modal is used to add or edit learning outcomes that correspond to each unit, usingOutcomeLearningServiceto associate it with a certain unit ID. The modal displays the title of the ILO, the abbreviation, and its description.Type of change
Frontend Migration
How Has This Been Tested?
Screenshots
Before:
After:
Testing Checklist:
Checklist: