-
Notifications
You must be signed in to change notification settings - Fork 137
Feature/Select Multiple Students #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.x
Are you sure you want to change the base?
Conversation
…on and UI updates
SahiruWithanage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Joe!
I have reviewed the PR and can confirm that selecting multiple students from the list functions correctly. Additionally, the POST request returns a 201 Created response as intended
Before merging, we should determine how this feature will interact with Pull Request #359, which also introduces multi-student selection. As this change is intended to support the “search student” functionality, it will be important to coordinate the integration of both PRs to prevent any conflicts.
Overall, the implementation is robust and straightforward to test. Please find this PR attached for your reference.
samindiii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Joe!
Great job- I was able to select multiple students from a list and access the API through that as well! Like Sahiru mentioned the merging is going to be quite messy but I'm sure we can figure it out :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file please
Description
This PR builds upon the existing Staff Grant Extension modal by introducing multi-student selection support. It allows admins to grant extensions to multiple students at once, improving flexibility and efficiency in bulk extension management.
This update extends the form implemented in PR #330 and includes the following changes:
Important: You may need to manually enter the URL, as there’s currently an issue accessing units while signed in as an administrator. As a workaround, you can sign in as a student first, copy the unit URL, then sign in as an admin and paste it into the address bar.
To View the Feature
Pull the frontend code from PR #330
For Reference:
Confirm multiple students can be selected
Confirm successful 201 created response

Type of change
Testing Checklist:
Checklist: