-
Notifications
You must be signed in to change notification settings - Fork 137
Migrate/Students-list #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 9.x
Are you sure you want to change the base?
Migrate/Students-list #356
Conversation
960cde3 to
5678ee9
Compare
5678ee9 to
96010fe
Compare
|
I tried running the branch locally but encountered a couple of build-time Angular errors: Can you please check and add modules where necessary? Let me know once updated so I can re-review. Thanks! |
| <thead class="bg-gray-50"> | ||
| <tr> | ||
| <th class="sticky left-0 px-3 py-2"></th> | ||
| <th class="px-3 py-2 cursor-pointer" font-bold (click)="sortTableBy('student.username')"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove font-bold from the element attributes as font-bold here is not a valid HTML and has no effect.
amriith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @HasinduWelarathne please have a look at the commented changes, let me know if you need any help with that. Rest everything looks good to me. Good Work
chelaz1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration is done according to the migration guide and the old component has been removed, and the new component has been successfully linked and downgraded. Great work!
|
Hi @amriith Thank you for the suggestion. I removed the unused font-bold attribute from the header elements and tightened up the SCSS to use consistent font-weight styling for the student-list table |
|
There's some difference between the before and after:
These needs to be resolved. |
|
Updated: unified tab selector styling and disabled flag sorting to match original behavior. |
Title
Migrate Students-List Component
Description
This PR migrates the existing
students-listcomponent from AngularJS/CoffeeScript to Angular 17/TypeScript, adopting Angular Material and Tailwind CSS. All original functionality (search/typeahead, filters, sorting, progress bars, flag icons, campus/tutorial selects, CSV export, enrol modal, pagination, and row navigation) remains behaviorally identical.Component Review
Type of change
How Has This Been Tested?
Screenshots
Before:

After:

Testing Checklist
Checklist