Skip to content

fix/IDOR vulnerability #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atharv02-git wants to merge 8 commits into
base: app-attack-fixes
Choose a base branch
from
Open

fix/IDOR vulnerability #63

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b9de910
Imported role_helpers to implement Role Based Access Controls
atharv02-git May 6, 2025
56a3ecc
Reusing centralized role-checking logic by importing role_helpers mod…
atharv02-git May 6, 2025
a35aea1
Add role-based checks in UnitRoleEntity to prevent students from acce…
atharv02-git May 6, 2025
b0b1cef
Add my_role context to UnitRole serializer to enforce RBAC during API…
atharv02-git May 6, 2025
358a9f1
Add user: current_user to unit serializer to enable role-based filter…
atharv02-git May 6, 2025
c1593c2
Added role_helpers module to centralize and reuse RBAC logic across d…
atharv02-git May 6, 2025
a294e9d
Restoring all the changes as per 8.0.x
atharv02-git May 8, 2025
df0bdca
filtering out the staff_data object for non_staff_roles
atharv02-git May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/api/entities/unit_entity.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def can_read_unit_config?(my_role)
expose :tutorial_streams, using: TutorialStreamEntity, unless: :summary_only

# Expose staff before tutorials, so that their details are available
expose :staff, using: UnitRoleEntity, unless: :summary_only
expose :staff, using: UnitRoleEntity, unless: :summary_only, if: lambda { |unit, options| is_staff?(options[:my_role]) } # filtering out the staff_data object for non_staff_roles
expose :tutorials, using: TutorialEntity, unless: :summary_only
# expose :tutorial_enrolments, using: TutorialEnrolmentEntity, unless: :summary_only, if: lambda { |unit, options| is_staff?(options[:my_role]) }

Expand Down