-
Notifications
You must be signed in to change notification settings - Fork 129
Feature/import download tutorials csv backend #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.0.x
Are you sure you want to change the base?
Changes from all commits
f42e7ef
70a36b1
b68c763
58b5b07
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| code,abbreviation,unit_id,tutor_id,tutorial_stream | ||
| test,CS3,4,8, | ||
| ,FX1,1,2,Practical-1 | ||
|
Comment on lines
+1
to
+3
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we use the name of the tutor instead of their ID to make things easier if any changes to the CSV need to be made before importing? This would require the tutor to already be added as a unit role to the unit, and throw a warning for each row that has a tutor name that isn't part of the unit
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I could do that but isn't it much better to use ID since it is a unique identifier? If two tutors have the same name or if a tutor has two accounts with the same name but different IDs, how would we know which one to choose? I feel like it is bad practice to use name, which is not a primary key to identify a user, correct me if I'm wrong :) |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the endpoint be an extension to the unit entity? So that the unit_id is used from the endpoint and not required in the CSV
It would allow the exact same CSV to be imported into two different units
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand why this is necessary. Based on my understanding, two different units cannot have the same tutorials. Will there be a situation where multiple units would have the exact same tutorials given that the information provided in the csv is tutorial specific and tutorials are unit specific?