strings with invalid json characters are now handled correctly

[travis-leith]

fix for #40

[MangelMaxime]

Sorry, for the delay the problem with this proposition of encoder is that the decoder explicitly say that a string cannot be null.

Thoth.Json.Net/src/Decode.fs

Line 29 in 2a70134

let inline isString (token: JsonValue) = not(isNull token) && token.Type = JTokenType.String

In this case, I think you should write custom coders called nullableString or something like to explicitly mention that it allows null strings.

Or shadow the Decode.string and Encode.string with your own implementation.

[MangelMaxime]

I am closing but please feel free to discuss it further.

[MangelMaxime]

Wait, I think I read the change wrong now that I see the linked issue to it.

I will re-think my decision sorry about that.

[MangelMaxime]

Hello,

@travis-leith I am unable to produce failing test with the current version of Thoth.Json.Net.

Code I tried:

            testCase "a string with new line works" <| fun _ ->
                let expected = "\"a\\nb\""
                let actual =
                    Encode.string "a\nb"
                    |> Encode.toString 4

                equal expected actual

            testCase "a string with new line character works" <| fun _ ->
                let expected = "\"a\\\\nb\""
                let actual =
                    Encode.string "a\\nb"
                    |> Encode.toString 4

                equal expected actual

            testCase "a string with tab works" <| fun _ ->
                let expected = "\"a\\tb\""
                let actual =
                    Encode.string "a\tb"
                    |> Encode.toString 4

                equal expected actual

Can you please provide me with a reproduction code for your error?