Skip to content

Use CallerArgumentExpression for TestDataRow by default. #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-gasser wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use CallerArgumentExpression for TestDataRow by default. #5135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions TUnit.Core/TestDataRow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
using System.Runtime.CompilerServices;

namespace TUnit.Core;

/// <summary>
Expand All @@ -20,7 +22,7 @@ internal interface ITestDataRow
/// <typeparam name="T">The type of the test data.</typeparam>
/// <param name="Data">The actual test data to be passed to the test method.</param>
/// <param name="DisplayName">
/// Optional custom display name for the test case.
/// Optional custom display name for the test case. If not specified, the argument expression from <paramref name="Data"/> is used.
/// Supports parameter substitution using $paramName or $arg1, $arg2, etc.
/// </param>
/// <param name="Skip">
Expand All @@ -33,15 +35,15 @@ internal interface ITestDataRow
/// <code>
/// public static IEnumerable&lt;TestDataRow&lt;(string Username, string Password)&gt;&gt; GetLoginData()
/// {
/// yield return new(("admin", "secret123"), DisplayName: "Admin login");
/// yield return new(("admin", "secret123")); // DisplayName '("admin", "secret123")' is inferred
/// yield return new(("guest", "guest"), DisplayName: "Guest login");
/// yield return new(("", ""), DisplayName: "Empty credentials", Skip: "Not implemented yet");
/// }
/// </code>
/// </example>
public record TestDataRow<T>(
T Data,
string? DisplayName = null,
[CallerArgumentExpression(nameof(Data))] string? DisplayName = null,
string? Skip = null,
string[]? Categories = null
) : ITestDataRow
Expand Down
Loading