chore(deps): update tunit to 1.21.24

[thomhurst]

This PR contains the following updates:

Package	Type	Update	Change
TUnit	nuget	patch	1.21.6 → 1.21.24
TUnit.Logging.Microsoft	nuget	patch	1.21.6 → 1.21.24

---

Release Notes

thomhurst/TUnit (TUnit)

v1.21.24: 1.21.24

What's Changed

Other Changes

• Fix OpenTelemetry missing root span by reordering session activity lifecycle by @​Copilot in #​5245

Dependencies

• chore(deps): update tunit to 1.21.20 by @​thomhurst in #​5241
• chore(deps): update dependency stackexchange.redis to 2.12.8 by @​thomhurst in #​5243

Full Changelog: thomhurst/TUnit@v1.21.20...v1.21.24

v1.21.20: 1.21.20

What's Changed

Other Changes

• fix: respect TUnitImplicitUsings set in Directory.Build.props by @​thomhurst in #​5225
• feat: covariant assertions for interfaces and non-sealed classes by @​thomhurst in #​5226
• feat: support string-to-parseable type conversions in [Arguments] by @​thomhurst in #​5227
• feat: add string length range assertions by @​thomhurst in #​4935
• Fix BeforeEvery/AfterEvery hooks for Class and Assembly not being executed by @​Copilot in #​5239

Dependencies

• chore(deps): update tunit to 1.21.6 by @​thomhurst in #​5228
• chore(deps): update dependency gitversion.msbuild to 6.7.0 by @​thomhurst in #​5229
• chore(deps): update dependency gitversion.tool to v6.7.0 by @​thomhurst in #​5230
• chore(deps): update aspire to 13.2.0 - autoclosed by @​thomhurst in #​5232
• chore(deps): update dependency typescript to v6 by @​thomhurst in #​5233
• chore(deps): update dependency polyfill to 9.23.0 by @​thomhurst in #​5235
• chore(deps): update dependency polyfill to 9.23.0 by @​thomhurst in #​5236

Full Changelog: thomhurst/TUnit@v1.21.6...v1.21.20

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot.

[claude]

Code Review

This is a clean, automated dependency bump of TUnit from → (patch release) across both test projects.

Changes reviewed:

• tests/Dekaf.Tests.Integration/Dekaf.Tests.Integration.csproj: TUnit and TUnit.Logging.Microsoft updated to 1.21.20
• tests/Dekaf.Tests.Unit/Dekaf.Tests.Unit.csproj: TUnit updated to 1.21.20

Assessment:

The update is appropriate and straightforward:

• Patch version bump only — no breaking changes expected per semver
• The TUnit 1.21.20 release notes include bug fixes (BeforeEvery/AfterEvery hooks fix, TUnitImplicitUsings fix) and additive features (covariant assertions, string-to-parseable conversions, string length range assertions) — all safe to adopt
• Both test projects are updated in sync, which is correct since they share the same testing framework version
• No source changes — purely .csproj version pin updates

One minor observation (not blocking): The integration test project pins TUnit and TUnit.Logging.Microsoft with explicit versions (1.21.20), while other dependencies like Testcontainers.Kafka use floating * ranges. This is consistent with the existing pattern in the file and is a deliberate choice by Renovate to keep test framework versions explicit and reproducible — no issue here.

This PR is safe to merge. ✅

[claude]

Code Review

This is a clean, automated dependency bump of TUnit from 1.21.6 to 1.21.20 (patch release) across both test projects.

Changes reviewed:

• tests/Dekaf.Tests.Integration/Dekaf.Tests.Integration.csproj: TUnit and TUnit.Logging.Microsoft updated to 1.21.20
• tests/Dekaf.Tests.Unit/Dekaf.Tests.Unit.csproj: TUnit updated to 1.21.20

Assessment:

The update is appropriate and straightforward:

• Patch version bump only — no breaking changes expected per semver
• The TUnit 1.21.20 release notes include bug fixes (BeforeEvery/AfterEvery hooks fix, TUnitImplicitUsings fix) and additive features (covariant assertions, string-to-parseable conversions, string length range assertions) — all safe to adopt
• Both test projects are updated in sync, which is correct since they share the same testing framework version
• No source changes — purely .csproj version pin updates

One minor observation (not blocking): The integration test project pins TUnit and TUnit.Logging.Microsoft with explicit versions, while other dependencies like Testcontainers.Kafka use floating * ranges. This is consistent with the existing pattern in the file and is a deliberate choice by Renovate to keep test framework versions explicit and reproducible — no issue here.

This PR is safe to merge.

[claude]

Code Review (Follow-up)

Previous reviews have already covered this PR thoroughly. No new issues have emerged.

Summary: This is a clean automated patch bump of TUnit from 1.21.6 → 1.21.20 across both test projects (Dekaf.Tests.Unit and Dekaf.Tests.Integration). The changes are purely .csproj version pin updates — no source modifications.

Previous review comments remain accurate:

• Patch release — no breaking changes expected
• Bug fixes in this range (BeforeEvery/AfterEvery hooks, TUnitImplicitUsings) are beneficial
• Both projects updated in sync

Safe to merge. ✅

[claude]

Dependency Update Review: TUnit 1.21.6 → 1.21.20

This is a straightforward Renovate Bot patch update for TUnit and TUnit.Logging.Microsoft across both test projects. No concerns with the changes themselves.

What changed:

• TUnit and TUnit.Logging.Microsoft bumped from 1.21.6 to 1.21.20 in both Dekaf.Tests.Unit and Dekaf.Tests.Integration
• The 1.21.20 release includes bug fixes for TUnitImplicitUsings in Directory.Build.props, covariant assertions for interfaces/non-sealed classes, string-to-parseable type conversions in [Arguments], and BeforeEvery/AfterEvery hooks fixes

Observations:

1. Version pinning inconsistency: TUnit and TUnit.Logging.Microsoft are pinned to exact patch versions (1.21.20), while many other test dependencies use wildcard/floating versions (Testcontainers.Kafka, Microsoft.Testing.Extensions.HangDump, Verify.TUnit, OpenTelemetry, etc.). Consider whether TUnit should also use a floating minor version like 1.* or 1.21.* to reduce the frequency of these routine update PRs, or conversely, pin the other dependencies for reproducibility.

2. No Directory.Packages.props: The TUnit version is defined independently in two .csproj files. Since this repo already uses Directory.Build.props for shared settings, introducing Central Package Management (Directory.Packages.props) would allow managing TUnit and other shared test dependency versions in a single place, avoiding the need to update multiple .csproj files for each version bump. This would be a worthwhile follow-up improvement.

3. TUnit.Logging.Microsoft only in integration tests: The logging extension is present in Dekaf.Tests.Integration but not in Dekaf.Tests.Unit. This appears intentional (unit tests don't need the full logging stack), but worth confirming this is deliberate.

The update itself is safe to merge. The suggestions above are non-blocking improvements worth considering as follow-ups.

[claude]

Code Review (Follow-up: 1.21.24)

The PR has been updated since the previous review — the target is now 1.21.24 (previously 1.21.20). The diff remains clean: only .csproj version pin updates across both test projects.

What's new in 1.21.24:

• Fix for OpenTelemetry missing root span (reordering session activity lifecycle — #5245)

This is a low-risk, beneficial bug fix. No concerns with the update.

Previous suggestions status: The follow-up suggestions from prior reviews (Central Package Management, floating versions) remain open — none are expected to be addressed in this automated dependency PR.

Safe to merge. ✅

[claude]

Code Review

This PR has been reviewed multiple times as it was updated through intermediate TUnit versions. This is the final review for the current state: TUnit 1.21.6 → 1.21.24.

Changes:

• tests/Dekaf.Tests.Integration/Dekaf.Tests.Integration.csproj: TUnit and TUnit.Logging.Microsoft updated 1.21.6 → 1.21.24
• tests/Dekaf.Tests.Unit/Dekaf.Tests.Unit.csproj: TUnit updated 1.21.6 → 1.21.24

Assessment:

No issues. This is a clean automated patch bump touching only test project .csproj files — no src/ library code is modified, so the zero-allocation, ConfigureAwait(false), thread-safety, and memory leak rules are not in scope.

The 1.21.24 cumulative changes include:

• BeforeEvery/AfterEvery hooks fix — beneficial for test reliability
• TUnitImplicitUsings in Directory.Build.props fix — non-impacting here
• OpenTelemetry missing root span fix (reordering session activity lifecycle) — low risk
• Additive features (covariant assertions, string length assertions, string-to-parseable conversions) — no impact unless explicitly used

Both test projects are updated in sync, which is correct.

Outstanding suggestions from previous reviews (non-blocking):

• Central Package Management (Directory.Packages.props) to avoid multi-file version updates
• Consider whether TUnit should use a floating version range (1.*) to reduce routine update PR churn

Neither item is expected to be addressed in an automated dependency PR.

Safe to merge.