Allow specifying the role used for "system" messages#90
Open
elliotb wants to merge 2 commits intothmsmlr:mainfrom
Open
Allow specifying the role used for "system" messages#90elliotb wants to merge 2 commits intothmsmlr:mainfrom
elliotb wants to merge 2 commits intothmsmlr:mainfrom
Conversation
|
@elliotb you need to drop the |
elliotb
force-pushed
the
instructor_role
branch
from
c2418fb to
8b8e667
Compare
Author
Thanks, I've updated the adapters that follow this pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI's o1 series of models require that the "system" messages are passed with a role of "developer", rather than "system".
While the developer can pass their initial set of messages with the correct role, the messages generated by Instructor for things such as validation retries were always sent with a "system" role, and rejected by the API.
This PR introduces an additional option to the chat_completion function, allowing overriding the role used for these messages, specified as
:instructor_rolethat defaults to "system".