Skip to content

Fix system prompt doubling on retry#62

Open
srcrip wants to merge 1 commit intothmsmlr:mainfrom
srcrip:patch-1
Open

Fix system prompt doubling on retry#62
srcrip wants to merge 1 commit intothmsmlr:mainfrom
srcrip:patch-1

Conversation

@srcrip
Copy link
Copy Markdown

@srcrip srcrip commented Jun 12, 2024

I'm unsure if this is affecting anyone else, but for me, I get doubling of the system prompt on retries. This prevents it by checking if it's already in the messages context before trying to add it.

@thmsmlr
Copy link
Copy Markdown
Owner

thmsmlr commented Jun 24, 2024

Ah yea, a side effect of that recursive call. Good catch

@thmsmlr
Copy link
Copy Markdown
Owner

thmsmlr commented Jun 24, 2024

Can you make it a more precise check to ensure that it only checks the first value in the messages list and add some tests for this?

Copy link
Copy Markdown
Owner

@thmsmlr thmsmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants