Skip to content

fix(Llamacpp): Llamacpp.url/0 doesn't return the url that was set in config #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alvises wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Llamacpp): Llamacpp.url/0 doesn't return the url that was set in config #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/instructor/adapters/llamacpp.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ defmodule Instructor.Adapters.Llamacpp do
"<s>#{prompt}"
end

defp url() do
Keyword.get(config(), :url, "http://localhost:8080/completion")
def url() do
Keyword.get(config(), :api_url, "http://localhost:8080/completion")
end

defp chat_template() do
Expand Down
8 changes: 8 additions & 0 deletions test/instructor_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ defmodule InstructorTest do

:openai_mock ->
Application.put_env(:instructor, :adapter, InstructorTest.MockOpenAI)

nil ->
:ok
end
end

Expand Down Expand Up @@ -419,4 +422,9 @@ defmodule InstructorTest do
result |> Enum.to_list()
end
end

test "Llamacpp adapter gets the url from :api_url in config" do
Application.put_env(:instructor, :llamacpp, api_url: "http://1.2.3.4:8080/completion")
assert "http://1.2.3.4:8080/completion" == Instructor.Adapters.Llamacpp.url()
end
end