chore: Reduce explicit usage of new lines#338
Open
thompson-tomo wants to merge 38 commits intothlorenz:masterfrom
Open
chore: Reduce explicit usage of new lines#338thompson-tomo wants to merge 38 commits intothlorenz:masterfrom
thompson-tomo wants to merge 38 commits intothlorenz:masterfrom
Conversation
thompson-tomo
requested review from
AndrewSouthpaw and
PeterDaveHello
as code owners
Added a function to detect line endings in content.
Collaborator
|
@thompson-tomo Some new merge conflicts on this, unfortunately. |
Contributor
Author
|
All fixed. @AndrewSouthpaw & would be good to get your thoughts on #339 which is the successor to this. |
AndrewSouthpaw
requested changes
Apr 14, 2026
Collaborator
AndrewSouthpaw
left a comment
AndrewSouthpaw
left a comment
There was a problem hiding this comment.
Just a couple small nits
Contributor
Author
|
@AndrewSouthpaw feedback implemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses an array of toc contents which is only combined into a string at the end which reduces the explicit usage of EOL characters and increases readability.