fix: set CREATE_NO_WINDOW on tzutil exec to prevent console flash#15
Open
williammartin wants to merge 1 commit into
Open
fix: set CREATE_NO_WINDOW on tzutil exec to prevent console flash#15williammartin wants to merge 1 commit into
williammartin wants to merge 1 commit into
Conversation
When the calling process has no console (e.g. spawned with DETACHED_PROCESS), tzutil.exe allocates a fresh conhost on first stdio access, producing a visible window flash. Setting CREATE_NO_WINDOW gives tzutil a non-visible console, preventing the flash while still allowing cmd.Output() to capture the result via pipes. golang.org/x/sys is already in the module graph via golang.org/x/sys/windows/registry, so no new dependency is added. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16
No worries if you just want to close it, but I thought I'd just open a PR to demonstrate the proposed fix. Cheers.