Skip to content

fix: gtag is not defined #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leanhvu21042001 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: gtag is not defined #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/landing-site/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const GA_TAG_ID = import.meta.env.VITE_GOOGLE_ANALYTICS
<script is:inline define:vars={{ GA_TAG_ID }}>
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
window.gtag = gtag;
gtag('js', new Date());
gtag('config', GA_TAG_ID);
</script>
Expand Down
1 change: 1 addition & 0 deletions packages/site/src/layouts/base.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ const GA_TAG_ID = import.meta.env.VITE_GOOGLE_ANALYTICS
<script is:inline define:vars={{ GA_TAG_ID }}>
window.dataLayer = window.dataLayer || [];
function gtag(){dataLayer.push(arguments);}
window.gtag = gtag;
gtag('js', new Date());
gtag('config', GA_TAG_ID);
</script>
Expand Down
22 changes: 15 additions & 7 deletions packages/system/src/util/analytics-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,19 @@ export const track = <T extends keyof TrackingCustomEvents>(
event: T,
...data: TrackingCustomEvents[T] extends void ? [] : [TrackingCustomEvents[T]]
): void => {
import.meta.env.MODE === 'production'
? data[0] != null
? gtag('event', event, data[0])
: gtag('event', event)
: data[0] != null
? console.info('track', event, data[0])
: console.info('track', event);
if (import.meta.env.MODE === 'production') {
if (typeof window !== 'undefined' && typeof window.gtag === 'function') {
if (data[0] != null) {
window.gtag('event', event, data[0]);
} else {
window.gtag('event', event);
}
}
} else {
if (data[0] != null) {
console.info('track', event, data[0]);
} else {
console.info('track', event);
}
}
};