⚡ Bolt: Optimize path containment and string processing#120
⚡ Bolt: Optimize path containment and string processing#120thirdeyenation wants to merge 1 commit into
Conversation
Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced
os.path.commonpathwith pure lexicalstr.startswith()inhelpers/files.py:is_in_dirandplugins/_office/helpers/document_store.py:_is_relative_to. Used the walrus operator to avoid doublestr.find()calls inhelpers/dirty_json.py:get_start_pos.🎯 Why:
os.path.commonpathallocates lists and splits paths internally, which is very slow compared to simple string manipulation.Path.is_relative_tois also surprisingly slower in Python 3.12. Pure lexical string checks avoid filesystem I/O and provide the best performance. The list comprehension indirty_json.pyredundantly searched for substrings.📊 Impact: ~3.5x speedup for
is_in_dir, ~7.7x speedup for_is_relative_to, and ~1.15x speedup forget_start_pos.🔬 Measurement: Verified with local Python benchmark scripts iterating the function calls 100k-1M times. Ran
pytestsuite to ensure functionality remains correct.PR created automatically by Jules for task 3624851497040025534 started by @thirdeyenation