Skip to content

⚡ Bolt: Optimize path containment checks#116

Open
thirdeyenation wants to merge 1 commit into
mainfrom
bolt-optimize-is-in-dir-16476795143833012715
Open

⚡ Bolt: Optimize path containment checks#116
thirdeyenation wants to merge 1 commit into
mainfrom
bolt-optimize-is-in-dir-16476795143833012715

Conversation

@thirdeyenation
Copy link
Copy Markdown
Owner

💡 What:
Replaced os.path.commonpath with a much faster string matching alternative (str.startswith with proper slash handling) in is_in_dir of helpers/files.py.

🎯 Why:
os.path.commonpath is relatively slow because it involves converting paths to arrays and splitting them internally. Since is_in_dir is often used to ensure paths don't escape safe boundaries, this operation can act as a bottleneck during rapid file processing.

📊 Impact:
Microbenchmarks show a ~3.5x performance improvement (0.71s vs 0.20s for 100k calls).

🔬 Measurement:
A benchmark script was created and run testing 100,000 iterations of both versions of the method on a sample path.


PR created automatically by Jules for task 16476795143833012715 started by @thirdeyenation

Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant